kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

On 08/25/2017 04:44 PM, Wayne Stambaugh wrote:
> Looks good to me.  Orson, would you please merge this when you get a chance?

Done. Matthias, thank you for your patch!

Regards,
Orson

> On 8/25/2017 9:51 AM, Maciej Sumiński wrote:
>> Hi Matthias,
>>
>> Your patch looks good to me. I would love to see the same change done
>> for via hole and diameter text controls.
> 
> Even better would be to derive an object (EDA_COORDINATE_VALIDATOR?)
> from wxTextValidator or one of it's decedents which can be used by any
> control that allows text editing.  Rather than use a separate static
> text control to display the units, just embed the units in the text
> control itself which can be edited by the user including entering
> coordinates in units other than the current unit type.  Just food for
> thought.
> 
>>
>> Regarding inch vs mil, IMHO mils are better suited for PCB design.
>> Still, I would rather keep pcbnew consistent, so I suppose we should
>> stay with inches for the time being.
>>
>> Regards,
>> Orson
>>
>> On 08/24/2017 09:16 PM, Mathias Grimmberger wrote:
>>>
>>> Hi all,
>>>
>>> Mathias Grimmberger <mgri@xxxxxxxxxxxxx> writes:
>>>>
>>>> Hi Wayne,
>>>>
>>>> Wayne Stambaugh <stambaughw@xxxxxxxxx> writes:
>>>>
>>>>> Rather than add a wxComboBox to the WX_UNIT_BINDER object, wouldn't be
>>>>> be cleaner to change wxTextCtrl* to wxTextEntry* which wxComboBox and
>>>>> wxTextCtrl (along with several others) are derived from?
>>>>
>>>> Yes, of course, I will change that.
>>>
>>> Here is the version of the patch with a nicer modification to
>>> WX_UNIT_BINDER.
>>>
>>> BTW, I noticed that displaying e.g. track width in inches feels somehow
>>> strange, would people like having selected values displayed in mils?
>>>
>>>
>>> Have fun,
>>>
>>> MGri
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature