← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] PcbNew Eagle Plugin: Remove layer restriction on some graphic items, fix undrawn items and place values on fabrication layers.

 

On 8/27/2017 4:39 AM, Russell Oliver wrote:
> Hi All, 
> 
> Attached is a patch that does some minor code changes in the PcbNew
> Eagle plugin which solves a few issues I encountered while testing the
> eagle schematic plugin and project import feature. 
> 
> The first was that some footprints such as Wifi trace antennas use
> graphic lines to form the footprint, but the plugin restricted the
> import of lines and other items to non-copper layers. I think that if
> you are prepared to import Eagle boards into Kicad you should be
> prepared to check all your footprints for issues and not have the plugin
> presuppose that lines on copper layers shouldn't exist. 

I agree that graphics items define on copper layers should be imported
to the appropriate copper layer in KiCad.  Is this going to cause any
issues with the known module pad limitations?  I know JP is working on a
complex pads solution for Pcbnew.  JP, any comments?

> 
> The second is matching the Eagle tValues and bValues layers with the
> kicad Fabrication layers instead of the silkscreen layers, to match
> current standard Kicad practive for component values. 

I would think users will expect any object to import to the same layer
that they are defined in Eagle.  If a module value object is on the
silkscreen layer in Eagle, then the imported value object should be on
the silkscreen layer.  Obviously, if there is a layer in Eagle that
doesn't exist in Pcbnew, then we will have to map it to the most logical
layer in KiCad.

> 
> The third is that some EDGE_MODULE board items were not being drawn due
> to missing calls to EDGE_MODULE::SetDrawCoord(). 
> 
> Kind Regards
> Russell
> 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References