kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #30492
Re: Minor patch for design rules editor
Bastian,
I committed your patch to the master branch. Thank you for your
contribution to KiCad.
Since your patch fixed a bug I used it as is. In the future, please use
wxUpdateUIEvent[1] for updating UI elements. I would prefer not to use
wxCommandEvents to attempt to keep track of UI element states because as
your patch clearly demonstrates, it often breaks down. I realize that
you did not write the original code but this has happened so many times
that I am to the point where I will no longer accept patches that
continue this practice.
Thanks,
Wayne
[1]:
http://docs.wxwidgets.org/3.0/classwx_update_u_i_event.html#a24daac56f682b866baac592e761ccede
On 8/28/2017 3:55 PM, Bastian Neumannn wrote:
> Hi,
>
> I attached a small patch that fixes a bug with the design editor.
> Loading a design with micro vias enabled loads the flag and sets the
> checkbox.
> The two input fields are not enabled when the design is loaded.
>
> Cheers
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References