kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I prefer "Worksheet Editor" but either one works for me.  If no one else
objects, I would go with that.

On 8/29/2017 3:53 PM, Michael Kavanagh wrote:
> Cheers! Sorry about the policy violations, I'll be more careful next time.
> Which of "Worksheet Editor"/"Worksheet Layout Editor" would be the
> preferred application name? I like the former best.
> 
> Regards,
> Michael
> 
> On 29 August 2017 at 17:25, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Michael,
> 
>     I committed your patch to the master branch.  Thank you for your
>     contribution to KiCad.  I did notice a few minor coding policy issues.
>     It appears that you followed the previous coding violations (missing
>     spaces between braces) when you made some of your changes.  In the
>     future, please fix coding policy violations when you find them.
> 
>     Thank you for deciding to look into the worksheet transition as a
>     separate patch.  I don't know how long you have been lurking on the
>     developers mailing list but the preference is small patches whenever
>     possible.  It makes reviewing them far easier.
> 
>     Cheers,
> 
>     Wayne
> 
>     On 8/29/2017 11:14 AM, Michael Kavanagh wrote:
>     > Hi,
>     >
>     > I have attached an updated patch, reverting back to the "Append"
>     > terminology. I will look into transitioning over to using "worksheet"
>     > but this looks like a fairly big task.
>     >
>     > Regards,
>     > Michael
>     >
>     > On 29 August 2017 at 09:35, Michael Kavanagh <michael@xxxxxxxxxxxxxxxxxx <mailto:michael@xxxxxxxxxxxxxxxxxx>
>     > <mailto:michael@xxxxxxxxxxxxxxxxxx <mailto:michael@xxxxxxxxxxxxxxxxxx>>> wrote:
>     >
>     >     Hi Orson,
>     >
>     >     I used that term because I felt it was more 'user friendly' than
>     >     append. I shall attach an updated patch when I get the chance
>     >     hopefully tonight.
>     >
>     >     Following from Olivers message on "[PATCH] minor icon improvements",
>     >     I noticed the KiCad manager uses the term "Worksheet layout editor"
>     >     in the tooltip for the page layout editor in the main toolbar. Do
>     >     people prefer the term "Page layout" or "worksheet"? I prefer the
>     >     latter as in my opinion its more succinct and less likely to confuse
>     >     "page layout" with "page settings". I can include the changes to
>     >     using "worksheet" in the same patch if you think this is a good idea.
>     >
>     >     Regards,
>     >     Michael
>     >
>     >     On 29 August 2017 at 08:16, Maciej Sumiński <maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>
>     >     <mailto:maciej.suminski@xxxxxxx
>     <mailto:maciej.suminski@xxxxxxx>>> wrote:
>     >
>     >         Hi Michael,
>     >
>     >         Thank you for your contribution. I like the changes, but I
>     would
>     >         keep
>     >         'Append' rather than 'Import'. In my opinion it is a better
>     >         description
>     >         for the action.
>     >
>     >         Regards,
>     >         Orson
>     >
>     >         On 08/27/2017 11:12 PM, Michael Kavanagh wrote:
>     >         > Dear All,
>     >         > I am a university EEE student looking to start
>     contributing to
>     >         the KiCad
>     >         > project. I have little/no experience with such large coding
>     >         projects so am
>     >         > starting small. Through my summer internships I have gained
>     >         some good
>     >         > experience with "Enterprise Class" EDA tools.
>     >         > Please find attached my first small patch with some UI
>     >         improvements for the
>     >         > page layout editor.
>     >         > Hopefully this is okay. Please let me know if there is
>     >         anything I need to
>     >         > change.
>     >         > Kind regards,
>     >         > Michael
>     >         >
>     >         >
>     >         >
>     >         > _______________________________________________
>     >         > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >         > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >         <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >         >
>     >
>     >
>     >
>     >         _______________________________________________
>     >         Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >         Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >         <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >
>     >
>     >
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>