← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Improved zoom behavior on MacOS

 

Hi Bernhard,

Please try the attached.

Thanks,
Jon

On Wed, Sep 13, 2017 at 6:56 AM, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx
> wrote:

> Hi,
>
> I am getting
> patch: **** malformed patch at line 52: @@ -178,6 +181,7 @@ void
> WX_VIEW_CONTROLS::onWheel( wxMouseEvent& aEvent )
>
> Can you resend?
>
>
> Regards,
> Bernhard
>
>
> On 13. Sep 2017, at 11:09, Maciej Suminski <maciej.suminski@xxxxxxx>
> wrote:
>
> Hi Jon,
>
> The patch looks good to me. I am willing to merge it as soon as it
> receives some positive feedback from the Mac users.
>
> Regards,
> Orson
>
> On 09/12/2017 05:16 PM, Jon Evans wrote:
>
> Hi,
>
> This patch changes the way middle wheel events are handled on MacOS.
> In my testing, this new behavior feels way better when using Apple
> trackpads, and also seems to work fine with the normal wheel on my external
> mouse.
>
> Mac users, I'd appreciate some testing to see if the behavior is worse than
> the existing one in any use cases.  Since MacOS provides wheel event
> acceleration at the OS level, we shouldn't need our own acceleration
> management code, but maybe there are some situations where the old code
> works better?
>
> Thanks,
> Jon
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>

Attachment: 0001-Improved-zoom-behavior-on-MacOS.patch
Description: Binary data


Follow ups

References