← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add support for panning with left and right mouse buttons

 

Hi Orson and Bernhard,

1) If the left-click pan setting is enabled, it does conflict with
left-click dragging (to make a group selection, for example).  I do not
enable left-click pan anywhere by default, I just added it in case there is
a single-function "pan tool" ever desired, like what is available in most
PDF readers.

2) If the right-click pan setting is enabled, it only handles drag events,
so in my testing, you can still use the right click menus just fine
(because it is a click without a drag).  I would welcome feedback if anyone
tests this and finds that it causes issues with right-click.

3) This setting is currently only enabled in my GerbView GAL branch, so if
you want to test it on master, you will have to just force the default to
enable right-click pan, and then it will also work in pcbnew.

4) The reason for this change is that the "touchpad pan" option allows you
to pan with the touchpad but not zoom, since it is using the same events.
My patch allows (in some tools, when appropriate) four different actions
without leaving the mouse/touchpad:  Left click to select, Right click for
context menu, mouse wheel, and right-drag for pan.  On an Apple touchpad at
least, this lets you both zoom and pan with just gestures.  This new patch
is not specific to MacOS though, I have tested it on Linux as well and with
various mice in addition to the Mac touchpad.  On regular mice with wheel
it also allows you to select, zoom, and pan at the same time.

Best,
Jon

On Wed, Sep 13, 2017 at 6:51 AM, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx
> wrote:

> Hi,
>
> Did you try (at least for laptops) the existing touchpad panning - instead
> of introducing yet another panning mode?
> The 2-finger panning gestures should meanwhile also be available on
> Windows/Linux?
>
>
> Regards,
> Bernhard
>
> > On 13. Sep 2017, at 11:21, Maciej Suminski <maciej.suminski@xxxxxxx>
> wrote:
> >
> > Hi Jon,
> >
> > I apologize for delayed replies, I have very limited time for KiCad
> > development recently.
> >
> > I do not mind adding such setting, but does not it cause issues with
> > right-click menus or left mouse button click actions?
> >
> > Regards,
> > Orson
> >
> > On 09/06/2017 03:31 AM, Jon Evans wrote:
> >> Hi all,
> >>
> >> This patch extends the VIEW_CONTROLS to allow optional panning with
> left or
> >> right buttons in addition to middle.  I plan to make use of this in
> >> GerbView for an easy panning mode that works well on laptops and
> 2-button
> >> mice, and this might also be useful in other applications -- drag-to-pan
> >> with the right button is a handy thing to enable in editing tools to
> make
> >> them usable when you don't have a middle button.
> >>
> >> -Jon
> >>
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References