← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Field editor buttons

 

Hi Oliver,
hups, sorry my bad. Please forget what I said ;-)

cheers
Fabrizio


On Fri, Sep 15, 2017 at 11:35 PM, Oliver Walters
<oliver.henry.walters@xxxxxxxxx> wrote:
> Hi Fabrizio,
>
> The icons I used were already in the bitmap_src directory, I didn't create
> any new ones? Or do I misunderstand what you mean?
>
>
> On 15 Sep 2017 23:45, "Fabrizio Tappero" <fabrizio.tappero@xxxxxxxxx> wrote:
>
> Dear Oliver,
>
> this patch add 4 new arrow icons (left, right, up, down) that where
> already present in kicad. Green button is also present, just need to
> be renamed appropriately.
>
> I would propose to make use of present icons whenever possible. kicad
> has now 494 icons that are very difficult to manage.
>
> cheers
> Fabrizio
>
>
> On Thu, Sep 14, 2017 at 3:16 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
>> Oliver,
>>
>> I merged your patch set into the master branch.  Thank you for your
>> contribution to KiCad.  FYI, I fixed a few coding policy violations:
>>
>> +    m_FieldsBuf[fieldNdx + 1].SetId(fieldNdx + 1);
>>
>>                                      ^           ^
>>                                      missing spaces
>>
>> Cheers,
>>
>> Wayne
>>
>> On 9/12/2017 3:50 AM, Oliver Walters wrote:
>>> Attached is a patch set that simplifies the UI buttons for organising
>>> component fields, both in the symbol editor and the schematic viewer.
>>>
>>> Screenshot: http://i.imgur.com/YFjASPT.png
>>>
>>> Cheers,
>>>
>>> Oliver
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>


References