← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] minor icon improvements

 

Fabrizio,

I merged your patch into the master branch.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 9/14/2017 6:59 AM, Fabrizio Tappero wrote:
> Hi Wayne,
> reviewed the patch and re-submit here. Changes are:
> 
> 1) "Edit PCB" is now "Edit PCB Layout"
> 2) "View GERBER" is now "View Gerber Files"
> 3) "Edit Schematic Symbol" is now "Manage Symbol Libraries"
> 4) "Edit Sheet Layout" is now "Edit Page Layout"
> 5) "Convert Bitmap to Footprint" is now "Convert Image"
> 
> This should include all the suggestions in this email chain.
> Thanks a lot
> Fabrizio
> 
> 
> 
> On Tue, Sep 12, 2017 at 5:00 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Fabrizio,
> 
>     Did you submit a revised patch with the suggestions that I made?  I just
>     looked in the mailing list archives and all I see is the original patch.
> 
>     Cheers,
> 
>     Wayne
> 
>     On 9/12/2017 8:57 AM, Fabrizio Tappero wrote:
>     > gentle reminder 
>     >
>     > cheers
>     > Fabrizio
>     >
>     >
>     > On Tue, Aug 29, 2017 at 7:12 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:
>     >
>     >     On 8/29/2017 12:44 PM, Simon Küppers wrote:
>     >     > -    Run Pcbnew
>     >     >
>     >     > +   Edit PCB
>     >     >
>     >     > What about "Edit PCB Layout" orientiert "Edit PCB Design"? Sounds more
>     >     > professional imho.
>     >
>     >     I'm fine with "Edit PCB Layout".
>     >
>     >     >
>     >     >
>     >     > Am 29. August 2017 10:04:19 MESZ schrieb Fabrizio Tappero
>     >     > <fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>
>     <mailto:fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>>>:
>     >     >
>     >     >     Hi Wayne,
>     >     >     it sound good. 
>     >     >     I think "Run" should go and I think "Edit Schematic" in
>     place of
>     >     >     "Run Eeschema" is a great step up.
>     >     >
>     >     >     The considerations about the use of the words "Symbol"
>     and "Table"
>     >     >     sound good too.
>     >     >
>     >     >     I changed the patch accordingly and resubmitted here.
>     Just as
>     >     >     reference, this is what I came up with:
>     >     >
>     >     >     -    Run Eeschema
>     >     >     +   Edit Schematic
>     >     >
>     >     >     -    Run Library Editor
>     >     >     +   Edit Schematic Symbol
>     >     >
>     >     >     -    Run Pcbnew
>     >     >     +   Edit PCB
>     >     >
>     >     >     -    Run Footprint Editor
>     >     >     +   Edit PCB Footprint
>     >     >
>     >     >     -    Run Gerbview
>     >     >     +   View GERBER
>     >     >
>     >     >     -    Run Bitmap2Component
>     >     >     +   Convert Bitmap to Footprint
>     >     >
>     >     >     -    Run Pcb Calculator
>     >     >     +   Run PCB Calculator
>     >     >
>     >     >     -    Run Page Layout Editor
>     >     >     +   Edit Sheet Layout
>     >     >
>     >     >     Wayne, please feel free to change the content of this
>     patch as you
>     >     >     think it is best.
>     >     >
>     >     >     cheers
>     >     >     Fabrizio
>     >     >
>     >     >
>     >     >
>     >     >
>     >     >
>     >     >     On Mon, Aug 28, 2017 at 9:00 PM, Wayne Stambaugh
>     >     >     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
>     >     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>> wrote:
>     >     >
>     >     >         Fabrizio,
>     >     >
>     >     >         I'm fine with the icon changes.  The menu entry
>     changes could
>     >     >         use some
>     >     >         improvement.  I'm not sure removing "Run" from the KiCad
>     >     >         launcher menu
>     >     >         entries is a good idea.  Generally (at least in most
>     of the
>     >     >         applications
>     >     >         that I've looked at), actions are used in menu
>     string when the
>     >     >         entry is
>     >     >         an action.  I also think it's probably time to get
>     rid of
>     >     the old
>     >     >         Eeschema/Pcbnew application names.  Since KiCad normally
>     >     runs in a
>     >     >         single process, better menu entries might be "Edit
>     Schematic"
>     >     >         and "Edit
>     >     >         Board (or PCB)".  New users aren't going to know what
>     >     Eeschema and
>     >     >         Pcbnew are.
>     >     >
>     >     >         I would also would not refer to the footprint
>     library "table"
>     >     >         either.
>     >     >         The word table seems to confuse users.  I know we
>     refer to
>     >     it as
>     >     >         a table
>     >     >         on the developers mailing list but I think users are
>     more
>     >     >         comfortable
>     >     >         with "Manage Footprint Libraries".  I am aware that
>     I used
>     >     table
>     >     >         for the
>     >     >         symbol library table dialog menus entry but this is
>     >     temporary. 
>     >     >         Once I
>     >     >         finish the symbol library table remapping code, this
>     >     dialog will
>     >     >         go away
>     >     >         and "Manage Symbol Libraries" will open the symbol
>     library
>     >     table
>     >     >         edit
>     >     >         dialog.
>     >     >
>     >     >         The use of symbol was intentional so I would prefer that
>     >     it not be
>     >     >         changed.  There was a discussion about this not too long
>     >     ago and the
>     >     >         consensus was that symbol made the most sense versus
>     component
>     >     >         or part.
>     >     >         I realize that component (and part) are used in the
>     source
>     >     code
>     >     >         and most
>     >     >         of the UI strings but I would prefer that we change
>     the UI
>     >     >         strings to
>     >     >         symbol for the stable 5 release rather than continue
>     to use
>     >     >         component
>     >     >         and/or part.  I will change the source when I get a
>     chance so
>     >     >         that the
>     >     >         terminology is coherent between the source and the UI
>     >     strings. 
>     >     >         I know
>     >     >         we still have the module/footprint distinction in
>     the Pcbnew
>     >     >         source but
>     >     >         at least all of the UI strings are "footprint".
>     >     >
>     >     >         Cheers,
>     >     >
>     >     >         Wayne
>     >     >
>     >     >         On 8/22/2017 5:47 PM, Fabrizio Tappero wrote:
>     >     >         > Reminder.
>     >     >         >
>     >     >         > Regards
>     >     >         > Fabrizio
>     >     >         >
>     >     >         >
>     >     >         > On Aug 17, 2017 4:42 PM, "Fabrizio Tappero"
>     >     <fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>
>     <mailto:fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@xxxxxxxxx>>
>     >     <mailto:fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>
>     <mailto:fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@xxxxxxxxx>>>
>     >     >         > <mailto:fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>
>     >     <mailto:fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>>
>     >     <mailto:fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>
>     >     <mailto:fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>>>>>
>     >     >         wrote:
>     >     >         >
>     >     >         >     Hello,
>     >     >         >     the following patch does the following:
>     >     >         >     1) correct few pcbnew and eeschema menu text
>     entries
>     >     >         >     2) add the library table icon (minor look change)
>     >     >         >     3) delete the redundant word "Run" into the
>     KiCad - Tools menu entry
>     >     >         >
>     >     >         >     cheers
>     >     >         >     Fabrzio
>     >     >         >
>     >     >         >
>     >     >         >
>     >     >         > _______________________________________________
>     >     >         > Mailing list:
>     https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >         > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>     >     >         > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >         > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >         <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>
>     >     >         >
>     >     >
>     >     >         _______________________________________________
>     >     >         Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>     >     >         Unsubscribe :
>     https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >         More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >         <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>
>     >     >
>     >     >
>     >     >
>     >     >
>     >     > _______________________________________________
>     >     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >
>     >
>     >     _______________________________________________
>     >     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >
>     >
> 
> 


References