← Back to team overview

kicad-developers team mailing list archive

Re: wxAuiNotebook vs. wxNotebook

 

In that case since I don't see why the Aui features are needed in the About
dialog I submit this patch for review. I have only tested on Windows 10 so
it should be tested on macOS etc. before merging.

Regards,
Michael

On 19 September 2017 at 18:03, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

> The thought was at some point we would switch over to wxAuiManager[1] to
> handle all window management.  That never happened because wxAui has not
> proven to be reliable enough to convert everything over to it.
> Hopefully at some point this will happen as it pulls in some nice
> features such as dockable/editable toolbars and child windows.  I'm not
> sure in the case of dialogs that using wxAuiNotebook buys us much over
> wxNotebook.
>
> [1]: http://docs.wxwidgets.org/3.0/overview_aui.html
>
> On 9/19/2017 12:15 PM, Michael Kavanagh wrote:
> > Hi,
> >
> > Is there any reason why wxAuiNotebook is used in some cases instead
> > of wxNotebook which uses native widgets? I have attached screenshots of
> > the different appearances on Windows.
> >
> > I can send some patches changing some over to wxNotebook if this is
> > acceptable. For the About dialog at least it seems to be a trivial
> > change (I suspect I am wrong on this) and improves the look. Note I am
> > still working on the icons for each tab.
> >
> > Regards,
> > Michael
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: 0001-Change-About-dialog-from-wxAuiNotebook-to-wxNotebook.patch
Description: Binary data


Follow ups

References