kicad-developers team mailing list archive

[Seppe Stas <seppestas@xxxxxxxxx>]

Yeah, I agree. The same goes for the name of the C++ modules… A “layer widget” that contains both “Layers” and “Renders” is a bit weird…

I think the title and name of the module should be changed to something like “render option” or “display options”, and “Render” could be further split into “Footprint Data” and “Other” (or like Fabrizio sugested just “Others”).




On 22 September 2017 at 17:16:22, Fabrizio Tappero (fabrizio.tappero@xxxxxxxxx) wrote:

Hi, 
since we talk about the "Visibles" menus. I find current naming a little unusual.

I would like to propose the following change.

"Visible" -> Eliminate this tirle
"Layer" -> "Visible Layers"
"Render" -> "Others"

Is it just me that I find this naming strange? Does anybody have a better idea?

cheers
Fabrizio




On Fri, Sep 22, 2017 at 3:12 PM, Seppe Stas <seppestas@xxxxxxxxx> wrote:
Hey Wayne

I fixed the coding policy violations. I blame my text-editor's trailing whitespace detector being broken all of a sudden and the spaces thing being weird XD.

The updated patches are attached to this mail. Let me know if you find any other issues.

Greetings
Seppe

2017-09-22 13:35 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
Seppe,

Please fix your coding policy[1] violations.  I saw some missing spaces
between brackets and function call arguments along with some trailing
white space.

Thanks,

Wayne

[1]:
http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html

On 9/22/2017 5:21 AM, Maciej Sumiński wrote:
> Hi Seppe,
>
> This is a very good idea. I would have merged the patch, but you need to
> implement GERBER_LAYER_WIDGET::OnLayerRightClick(), as in the current
> state the code does not compile.
>
> Regards,
> Orson
>
> On 09/21/2017 06:25 PM, Seppe Stas wrote:
>> This patch makes it possible to change the color of layers and render
>> options using the right click menu. See attached picture:
>> [image: Inline afbeelding 1]
>>
>> The motivation for this is the current "double left click / middle click"
>> being somewhat obscure. I've been using KiCad for over 2 years and recently
>> found out about the double click method by looking at KiCad's source code
>> (I stumbled on the middle mouse button method earlier). At one point I even
>> borrowed a mouse from my colleague to change layer colors when I needed to
>> open a 6 layer board since I typically use a trackpad without a middle
>> mouse button. My colleagues, most of whom have been using KiCad for longer
>> than me, didn't even know changing the layer/render color is possible.
>>
>> Being able to change properties of a selected item using the right mouse
>> button is a lot more common in modern GUI applications and is more
>> consistent with how the rest of pcbnew works.
>>
>> Greetings
>> Seppe Stas
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Attachment: signature.asc
Description: Message signed with OpenPGP using AMPGpg