kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi Camille,

I think the attached patches are sensible, even though I hope most
compilers apply optimizations to avoid performance penalties whenever
possible.

If the attached patches are autogenerated, then I would kindly ask you
to generate them when we reach the feature freeze stage. There are a few
branches that await to be merged and I am not sure whether your patches
would not create too many conflicts. During the feature freeze we
anticipate the code changes will not be as disruptive as they are now.

Regards,
Orson

On 09/23/2017 12:17 PM, Camille 019 wrote:
> Hi all,
> 
> 
> I recently play with clang-tidy on the KiCad source code. Here is a set of 2 patch which fix the unnecessary-copy-initialization<https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-copy-initialization.html> and unnecessary-value-param<https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html> checks.
> 
> 
> I will run more performance checks in the future. The next two:
> 
> - for-range-copy<https://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html>
> 
> - type-promotion-in-math-fn<https://clang.llvm.org/extra/clang-tidy/checks/performance-type-promotion-in-math-fn.html>
> 
> 
> Best regards,
> 
> 
> --
> 
> Camille
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature