← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] PcbNew Eagle Plugin: Remove layer restriction on some graphic items, fix undrawn items and place values on fabrication layers.

 

Hi Russell,

Would you provide a board example that would be affected by the change?
It would be very helpful to test the patch.

I am not really sure whether EDGE_MODULEs drawn on copper layers will be
exported to Gerbers and I am certain that they will not be taken into
account during DRC or zone fill calculations. If my suspicions are
correct, then IMHO presence of such footprints should lead to a warning
message and nothing more. Perhaps they could be converted to custom
shape pads, but I am not sure it is always applicable or trivial.

Regards,
Orson

On 09/20/2017 11:59 PM, Russell Oliver wrote:
> Wayne,
> 
> After my quick look at JP's custom pad code, I think the patch is still
> valid simply because it allows for the quick conversion between copper
> layer graphical items in an Eagle footprint to the equivalent KiCad item.
> Eagle Cad does not have an equivalent custom pad shape feature which groups
> graphical items as a pad within the footprint. As JP mentioned the
> conversion to a proper custom KiCad pad shape would be non trivial. I have
> seen Eagle users, use multiple graphical elements on separate layers to
> define a pad, e.g. A polygon for copper, another for paste, another for
> mask, and sometimes these do not overlap completely. Which if I assume
> correctly is not supported by a custom KiCad pad?
> 
> I'll  find some Eagle boards with custom footprints (mostly antenna's) to
> show how its being used.
> 
> Regards
> Russell
> 
> On Thu, Sep 21, 2017 at 1:26 AM Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
> 
>> Russell,
>>
>> Is this patch still valid now that JP merged his custom pad work or does
>> it need to be reworked to support custom pads?  I would like to get all
>> of the Eagle changes into master for the stable 5 branch.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 8/27/2017 4:39 AM, Russell Oliver wrote:
>>> Hi All,
>>>
>>> Attached is a patch that does some minor code changes in the PcbNew
>>> Eagle plugin which solves a few issues I encountered while testing the
>>> eagle schematic plugin and project import feature.
>>>
>>> The first was that some footprints such as Wifi trace antennas use
>>> graphic lines to form the footprint, but the plugin restricted the
>>> import of lines and other items to non-copper layers. I think that if
>>> you are prepared to import Eagle boards into Kicad you should be
>>> prepared to check all your footprints for issues and not have the plugin
>>> presuppose that lines on copper layers shouldn't exist.
>>>
>>> The second is matching the Eagle tValues and bValues layers with the
>>> kicad Fabrication layers instead of the silkscreen layers, to match
>>> current standard Kicad practive for component values.
>>>
>>> The third is that some EDGE_MODULE board items were not being drawn due
>>> to missing calls to EDGE_MODULE::SetDrawCoord().
>>>
>>> Kind Regards
>>> Russell
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References