kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Perfect, I have just committed your patch. Thank you!

Regards,
Orson

On 09/25/2017 11:11 PM, Jon Evans wrote:
> Thanks Orson.  The attached patch changes the d-code LOD threshold to a
> more reasonable value.
> 
> -Jon
> 
> On Mon, Sep 25, 2017 at 8:31 AM, Maciej Sumiński <maciej.suminski@xxxxxxx>
> wrote:
> 
>> Jon,
>>
>> Thank you very much for your work on GerbView GAL support. I have just
>> pushed your changes to the master branch, including the most recent
>> patches.
>>
>> The display performance is significantly better when compared to the
>> legacy renderer. Still, if you are interested in further improvements, a
>> cheap upgrade would be to take advantage of VIEW_ITEM::ViewGetLOD()
>> method to hide d-codes depending on the zoom level. It is done the same
>> way e.g. for track net labels.
>>
>> Regards,
>> Orson
>>
>> On 09/25/2017 03:26 AM, Jon Evans wrote:
>>> Hi Orson, Tom,
>>>
>>> Thanks for the tips.  I eventually did figure out what was going on --
>>> mismatch of state between the RTREE and the View in my first attempt at
>>> optimization.
>>>
>>> The attached 3 patches improve performance a ton on larger Gerber files
>> --
>>> on my computer, between 30-40% improvement, and massive improvement in
>> file
>>> load time and responsiveness when you select items.
>>> Please review and if you see no issues, apply on top of the existing
>> branch
>>> before you merge. (yes, there is no 0003- patch)
>>>
>>> (This should also be good for a performance boost in PcbNew when working
>>> with very large boards)
>>>
>>> Thanks,
>>> Jon
>>>
>>> On Sat, Sep 23, 2017 at 3:01 PM, jp charras <jp.charras@xxxxxxxxxx>
>> wrote:
>>>
>>>> Le 21/09/2017 à 14:04, Wayne Stambaugh a écrit :
>>>>> Orson,
>>>>>
>>>>> I'm leaving this decision up to you and JP since I have not had time to
>>>>> test it.  JP, do you have any other concerns about this?
>>>>
>>>> Sorry for the delay, but I was away last 3 days.
>>>> I do not have concerns about merging Gerbview GAL.
>>>>
>>>> We know there are a few issues, but they can be fixed later. None is
>>>> blocking.
>>>> And the legacy canvas can be used with no issue.
>>>>
>>>> So, Orson, if you can commit this very good enhancement, please do it.
>>>> AFAIK, remember also only the GAL canvas works on wxWidgets + GTK3, so
>> the
>>>> GAL canvas support is
>>>> very important for the future of KiCad.
>>>>
>>>> Thanks to Jon and Orson for all this work.
>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Wayne
>>>>>
>>>>> On 9/21/2017 6:05 AM, Maciej Sumiński wrote:
>>>>>> Hi Jon,
>>>>>>
>>>>>> Thanks you, this is really cool! Now it is even more tempting to merge
>>>>>> the gerbview_gal branch. I am going to wait one more day for vetos and
>>>>>> tomorrow I will push it to the master branch.
>>>>>>
>>>>>> Regards,
>>>>>> Orson
>>>>>>
>>>>>> On 09/20/2017 09:57 PM, Jon Evans wrote:
>>>>>>> Hi Orson,
>>>>>>>
>>>>>>> Give this a shot in your branch.  It should work in pcbnew also now.
>>>>>>>
>>>>>>> -Jon
>>>>>>>
>>>>>>> On Wed, Sep 20, 2017 at 9:28 AM, Jon Evans <jon@xxxxxxxxxxxxx>
>> wrote:
>>>>>>>
>>>>>>>> Hi Orson,
>>>>>>>>
>>>>>>>> Thank you for staging this for merge on your branch.  I checked and
>>>> you do
>>>>>>>> have all the patches.
>>>>>>>>
>>>>>>>> 1) Yes I planned on refactoring the selection tool once things
>>>> stabilized
>>>>>>>> with the highlighting etc.
>>>>>>>> 2) Do you mean when you are highlighting Gerber X2 attributes, or
>>>> when you
>>>>>>>> are deselecting things, or something else?
>>>>>>>> 3) That's a good idea on VIEW_GROUP, I will give it a try and send a
>>>> patch.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Jon
>>>>>>>>
>>>>>>>> On Wed, Sep 20, 2017 at 5:46 AM, Maciej Sumiński <
>>>> maciej.suminski@xxxxxxx>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi Jon,
>>>>>>>>>
>>>>>>>>> GALifying GerbView is a huge task, so thank you very much for your
>>>> work!
>>>>>>>>> I have just tested your changes and in my opinion it is in a state
>>>> that
>>>>>>>>> deserves merging and further tests. The new way of item
>> highlighting
>>>> is
>>>>>>>>> awesome, we need to port it to pcbnew as well.
>>>>>>>>>
>>>>>>>>> For now I keep your patches in a separate branch, with some minor
>>>>>>>>> modifications on top of it [1]. Please verify it contains all the
>>>> needed
>>>>>>>>> patches. If nobody objects, I would like to merge it this week.
>>>>>>>>>
>>>>>>>>> Just a few minor remarks:
>>>>>>>>> - It seems there is some code that could be refactored to share it
>>>> with
>>>>>>>>> pcbnew (e.g. selection tool).
>>>>>>>>> - 'Clear highlight' operation takes long time to finish (seems more
>>>> than
>>>>>>>>> with the legacy canvas), but I cannot really see what is happening
>>>>>>>>> there. If it cannot be easily fixed, perhaps it could set the mouse
>>>>>>>>> cursor to busy.
>>>>>>>>> - For the new highlighting method: perhaps a more universal way is
>> to
>>>>>>>>> create a temporary VIEW_GROUP object containing the selection
>>>> candidate.
>>>>>>>>> This way it can be temporarily displayed on the overlay layer,
>>>> without
>>>>>>>>> modifying the original ViewGetLayer() methods.
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Orson
>>>>>>>>>
>>>>>>>>> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/
>>>>>>>>> gerbview_gal
>>>>>>>>>
>>>>>>>>> On 09/18/2017 12:47 AM, Jon Evans wrote:
>>>>>>>>>> Hi all,
>>>>>>>>>>
>>>>>>>>>> The day has finally come!  I have distilled my GerbView GAL branch
>>>> into
>>>>>>>>> a
>>>>>>>>>> patchset attached to this email.  Hopefully with this merged into
>>>>>>>>> master we
>>>>>>>>>> can identify any remaining bugs and clean it up for 5.0.
>>>>>>>>>>
>>>>>>>>>> Note that this set is split into 5 patches to make review easier,
>>>> but
>>>>>>>>> they
>>>>>>>>>> are not intended to compile and work independently.
>>>>>>>>>>
>>>>>>>>>> Best,
>>>>>>>>>> Jon
>>>>
>>>>
>>>>
>>>> --
>>>> Jean-Pierre CHARRAS
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>

Attachment: signature.asc
Description: OpenPGP digital signature