← Back to team overview

kicad-developers team mailing list archive

[PATCH] 3D Viewer: Fix for labels from popup menu

 

In popup menu of 3D Viewer the entry for setting bottom view is labeled as
Top View (present two entries with label "Top View") and the entries for
move left/right has different writing style (left/right starts with lower
case).
Attached small patch fixess this.
From 1d8e16ebec5b4d846e248912510cb418bc4c3b40 Mon Sep 17 00:00:00 2001
From: Baranovskiy Konstantin <baranovskiykonstantin@xxxxxxxxx>
Date: Fri, 29 Sep 2017 16:13:42 +0300
Subject: [PATCH] 3D Viewer: fixed entry labels in popup menu.

---
 3d-viewer/3d_canvas/eda_3d_canvas.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/3d-viewer/3d_canvas/eda_3d_canvas.cpp b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
index 0306a9048..77c671c24 100644
--- a/3d-viewer/3d_canvas/eda_3d_canvas.cpp
+++ b/3d-viewer/3d_canvas/eda_3d_canvas.cpp
@@ -625,7 +625,7 @@ void EDA_3D_CANVAS::OnRightClick( wxMouseEvent &event )
     AddMenuItem( &PopUpMenu, ID_POPUP_VIEW_ZPOS,
                  msg, KiBitmap( axis3d_top_xpm ) );
 
-    msg = AddHotkeyName( _( "Top View" ), g_3DViewer_Hokeys_Descr,
+    msg = AddHotkeyName( _( "Bottom View" ), g_3DViewer_Hokeys_Descr,
                          ID_POPUP_VIEW_ZNEG );
     AddMenuItem( &PopUpMenu, ID_POPUP_VIEW_ZNEG,
                  msg, KiBitmap( axis3d_bottom_xpm ) );
@@ -656,12 +656,12 @@ void EDA_3D_CANVAS::OnRightClick( wxMouseEvent &event )
 
     PopUpMenu.AppendSeparator();
 
-    msg = AddHotkeyName( _( "Move left <-" ), g_3DViewer_Hokeys_Descr,
+    msg = AddHotkeyName( _( "Move Left <-" ), g_3DViewer_Hokeys_Descr,
                          ID_POPUP_MOVE3D_LEFT );
     AddMenuItem( &PopUpMenu, ID_POPUP_MOVE3D_LEFT,
                  msg, KiBitmap( left_xpm ) );
 
-    msg = AddHotkeyName( _( "Move right ->" ), g_3DViewer_Hokeys_Descr,
+    msg = AddHotkeyName( _( "Move Right ->" ), g_3DViewer_Hokeys_Descr,
                          ID_POPUP_MOVE3D_RIGHT );
     AddMenuItem( &PopUpMenu, ID_POPUP_MOVE3D_RIGHT,
                  msg, KiBitmap( right_xpm ) );
-- 
2.14.1


Follow ups