← Back to team overview

kicad-developers team mailing list archive

[PATCH] Pcbnew: small fix for pad properties dialog

 

In "Pad properties" dialog on "Local Clearance and Settings" tab last
option has some difference from others.
Attached patch makes label "Custom pad shape in zone:" aligned by vertical
center and removes right and top borders from wxChoice item (to make size
of it to be equivalent to other items in this column).
From 40dd8ef5eb07b202bf5e20f6233ee2a77d3e0712 Mon Sep 17 00:00:00 2001
From: Baranovskiy Konstantin <baranovskiykonstantin@xxxxxxxxx>
Date: Sun, 1 Oct 2017 16:34:07 +0300
Subject: [PATCH] Pcbnew: small fix for pad properties dialog.

---
 pcbnew/dialogs/dialog_pad_properties_base.cpp | 6 +++---
 pcbnew/dialogs/dialog_pad_properties_base.fbp | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pcbnew/dialogs/dialog_pad_properties_base.cpp b/pcbnew/dialogs/dialog_pad_properties_base.cpp
index 95e781cb5..77dd59461 100644
--- a/pcbnew/dialogs/dialog_pad_properties_base.cpp
+++ b/pcbnew/dialogs/dialog_pad_properties_base.cpp
@@ -1,5 +1,5 @@
 ///////////////////////////////////////////////////////////////////////////
-// C++ code generated with wxFormBuilder (version Jul  2 2017)
+// C++ code generated with wxFormBuilder (version Mar  1 2017)
 // http://www.wxformbuilder.org/
 //
 // PLEASE DO "NOT" EDIT THIS FILE!
@@ -531,13 +531,13 @@ DIALOG_PAD_PROPERTIES_BASE::DIALOG_PAD_PROPERTIES_BASE( wxWindow* parent, wxWind
 	
 	m_staticTextcps = new wxStaticText( m_sbSizerZonesSettings->GetStaticBox(), wxID_ANY, _("Custom pad shape in zone:"), wxDefaultPosition, wxDefaultSize, 0 );
 	m_staticTextcps->Wrap( -1 );
-	fgSizerCopperZonesOpts->Add( m_staticTextcps, 0, wxALL, 5 );
+	fgSizerCopperZonesOpts->Add( m_staticTextcps, 0, wxALL|wxALIGN_CENTER_VERTICAL, 5 );
 	
 	wxString m_ZoneCustomPadShapeChoices[] = { _("Use pad shape"), _("Use pad convex hull") };
 	int m_ZoneCustomPadShapeNChoices = sizeof( m_ZoneCustomPadShapeChoices ) / sizeof( wxString );
 	m_ZoneCustomPadShape = new wxChoice( m_sbSizerZonesSettings->GetStaticBox(), wxID_ANY, wxDefaultPosition, wxDefaultSize, m_ZoneCustomPadShapeNChoices, m_ZoneCustomPadShapeChoices, 0 );
 	m_ZoneCustomPadShape->SetSelection( 0 );
-	fgSizerCopperZonesOpts->Add( m_ZoneCustomPadShape, 0, wxALL|wxEXPAND, 5 );
+	fgSizerCopperZonesOpts->Add( m_ZoneCustomPadShape, 0, wxEXPAND|wxBOTTOM|wxLEFT, 5 );
 	
 	
 	fgSizerCopperZonesOpts->Add( 0, 0, 1, wxEXPAND, 5 );
diff --git a/pcbnew/dialogs/dialog_pad_properties_base.fbp b/pcbnew/dialogs/dialog_pad_properties_base.fbp
index 741a3885b..7f1f05331 100644
--- a/pcbnew/dialogs/dialog_pad_properties_base.fbp
+++ b/pcbnew/dialogs/dialog_pad_properties_base.fbp
@@ -8910,7 +8910,7 @@
                                                                     </object>
                                                                     <object class="sizeritem" expanded="1">
                                                                         <property name="border">5</property>
-                                                                        <property name="flag">wxALL</property>
+                                                                        <property name="flag">wxALL|wxALIGN_CENTER_VERTICAL</property>
                                                                         <property name="proportion">0</property>
                                                                         <object class="wxStaticText" expanded="1">
                                                                             <property name="BottomDockable">1</property>
@@ -8993,7 +8993,7 @@
                                                                     </object>
                                                                     <object class="sizeritem" expanded="1">
                                                                         <property name="border">5</property>
-                                                                        <property name="flag">wxALL|wxEXPAND</property>
+                                                                        <property name="flag">wxEXPAND|wxBOTTOM|wxLEFT</property>
                                                                         <property name="proportion">0</property>
                                                                         <object class="wxChoice" expanded="1">
                                                                             <property name="BottomDockable">1</property>
-- 
2.14.1


Follow ups