← Back to team overview

kicad-developers team mailing list archive

Re: Need testers for a patch to merge hotkeys and accelerators


I cannot compile, but I can test a windows 64 installer or binary in windows 7. And I know exactly how to duplicate and test the X and O key issue with python installed wx.Window. The earliest I can test is Friday evening (USA).

Greg S.

> On Oct 3, 2017, at 9:01 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:
> Hi All,
> Currently, when a key is used as hotkey and if we want to display it in a sub-menu of the main menu,
> because it becomes a accelerator key, we need to modify it (adding shift or alt modifier) when the
> action differs (uses the mouse position) when called from a menu or a key.
> Although there are not a lot of cases (zoom in and out are 2 cases, and there are more cases in
> Eeschema), this is annoying for 2 reasons:
> - Many users do not know the difference between a accelerator key and a hotkey.
> - 2 similar actions use 2 keys instead of only one key, and we do not have a lot of available keys
> for hotkeys, so wasting a few keys is very annoying.
> I wrote a patch to use the same key as accelerator key and hotkey.
> In fact, if a menu uses (for a accelerator key) the same key as a hotkey, the key event is not sent
> to this menu, and the "accelerator key" becomes just a comment in menu.
> To do that, the EVT_CHAR_HOOK key event is now managed by the main frame and is filtered, and not
> sent to the GUI if a hotkey handles this key event (this is the normal way to handle keys whenn we
> have special requirements).
> Unfortunately, the way EVT_CHAR_HOOK and EVT_CHAR key events are exactly working is highly dependent
> of platforms, and a bit tricky.
> I tested this patch on Windows 32 bits, and partially on Linux (I was not able to test the python
> console), but not on OSX.
> Obviously, it must be tested (both in legacy canvas and GEL canvas) on OSX, and Linux (and of course
> on Windows 64 bits), and especially with Pcbnew in python console:
> are all chars captured in the console, especially the 2 accelerators 'O' and 'X'
> Thanks.
> -- 
> Jean-Pierre CHARRAS
> <merge_hotkeys_and_accelerators.patch>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups