← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] UX for ENV_VAR editor

 

You can still type it in manually in my patch

On 8 Oct 2017 05:49, "Wayne Stambaugh" <stambaughw@xxxxxxxxx> wrote:

> On 10/7/2017 10:04 AM, jp charras wrote:
> > Le 06/10/2017 à 21:08, Wayne Stambaugh a écrit :
> >> Oliver,
> >>
> >> My original intention with this dialog was to do away with the "Add" and
> >> "Remove" buttons all together and create an object derived from
> >> wxGridTable and wxGrid for editing the environment variable list.  I did
> >> this because it was expedient.  I've never been a big fan of the way we
> >> use buttons to add, delete, edit, etc. entries in grids and list
> >> controls.  Why not just make them directly editable like a typical
> >> spreadsheet?  I would think that this would be more natural for users
> >> rather than using buttons.  It seems to me that double clicking (or
> >> right clicking and context menu) in the path grid cell would launch the
> >> dir select dialog.  I know it's more work to do it this way but I think
> >> it is a more user friendly approach than having to use buttons to modify
> >> the grid.
> >>
> >> That being said, I would be willing to commit this patch if you fix a
> >> few things in DIALOG_ENV_VAR_SINGLE_BASE:
> >>
> >> Make the dialog resizable so DIALOG_SHIM can do it's job.
> >>
> >> Don't allow the controls to expand.
> >>
> >> Don't allow the wxStdDialogButtonSizer to expand.
> >>
> >> Set the spacer proportion to 0.
> >>
> >> Use a wxDirPickCtrl instead of your own custom control.  It will be more
> >> consistent across platforms.
> >
> > I am not sure it is possible to set KIGITHUB env var value.
> > I believe entering a https URI is not possible with a wxDirPickCtrl at
> least on Windows.
>
> I forgot about that so wxDirPickerCtrl is out of the question unless you
> can type a URI in text edit control without any issues.
>
> >
> >>
> >> Get rid of the dialog size and let the sizers select the best size for
> >> the controls.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >> On 10/6/2017 10:53 AM, Oliver Walters wrote:
> >>> Attached is a patch which improves UX for the ENV_VAR editor dialog
> >>>
> >>> * Adds ability to select path with file chooser
> >>> * General cleanup
> >>> * Removal of that sinking feeling you get when interacting with a
> clunky UI
> >>>
> >>> Oliver
> >>
> >
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References