← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Eagle schematic and project import.

 

Hi Jean-Pierre,

On 09/25/2017 04:10 PM, jp charras wrote:
[snip]

> I have 2 different issues.
> 
> 1 - "Rounding" issues:
> Attached a .sch from Eagle, and the same after conversion to eeschema file.
> In the Eeschema file, many (most of?) wires are on the 1 mil grid (see for instance lines 51, 53,
> 55), not on the 25 or 50 mils grid.
> Same in the .lib file for many pins (see lines 129, 130 ... for instance in cache lib)

I have modified the Eagle parser to store coordinates using nanometers
stored as integers instead of millimeters stored in a double. Now the
coordinate string is manually processed to a value in nanometers without
invoking strtod() or similar conversion functions, so there should be no
rounding errors anymore.

> 2 - Library is broken (see the cache lib) after written on disk and cannot be loaded:
>  - some empty texts are in library (see line 108)
>  if a text is empty the dummy char ~ must be used in file as text string.

Thank you for noting, should be fixed now.

>  - some symbols ( I am thinking they could be multi units symbols) are incorrect.
> for instance see ELECTRON_SMT
> especially pins are broken: a pin like:
> X A2 10A 10B 10C -400 -100 100 R 50 50 1 0 U
> is perhaps a pin multi unit pin
> But the pin number (10A 10B 10C) cannot have spaces in string (space is not allowed in pin names and
> pin numbers).
> This line is broken.

Russell has fixed this.

If there are no other problems, I would like to merge the import plugin.
Fixed and rebased code is available in my launchpad git repository [1].

Regards,
Orson

1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/eagle-import

Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References