kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hi Jean-Samuel,

I committed your code to the master branch.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 10/19/2017 4:30 AM, Jean-Samuel Reynaud wrote:
> Hi,
> 
> Sorry, corrected patch attached.
> 
> Regards
> Le 18/10/2017 à 19:31, Wayne Stambaugh a écrit :
>> Hi Jean-Samuel,
>>
>> There are a few coding policy violations in your patch.
>>
>> if( outline.OutlineCount() > 0) {
>>
>> should be:
>>
>> if( outline.OutlineCount() > 0 )
>> {
>>
>> This occurs several times.  Please fix this as resubmit the patch.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 10/18/2017 8:58 AM, Jean-Samuel Reynaud wrote:
>>> Hi all,
>>>
>>> Since some recent modifications (I don't search from what version
>>> exactly), bug 1663173 is coming back...
>>>
>>> See original description : https://bugs.launchpad.net/kicad/+bug/1663173
>>>
>>> Please find attached the patch to fix it.
>>>
>>> Following this issue I have two comments:
>>>
>>> - For any usage of "poly->Point( 0 )" or anything like, this should be
>>> preceded by a check if value "0" is a valid value.
>>>  Like this:
>>>                 if( poly->PointCount() > 0)
>>>                 {
>>>                    // Use of poly->Point( 0 )
>>>
>>> Same with Outline :
>>>             if( outline.OutlineCount() > 0) {
>>>                 // Use of outline.Outline( 0 );
>>> Or any other way to ensure the index X (with X=0 in thoses case) is a
>>> valid index...
>>>
>>> - Is it really logic to allow negative clearance in pads ? Should not be
>>> an absolute value ? In this case, interface should avoid this case...
>>>
>>> Regards,
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>