← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 00/12] Minor cleanups and improvements

 

Hello Marvin,

Am 02.11.2017 um 21:58 schrieb Marvin Schmidt:
> Just a set of small code cleanups to fix a bunch of warnings
> and remove dead code.
> Other than that the 'build:' commits avoid/remove/fix the
> installation of certain files:
>  - it doesn't make much sense to install the INSTALL.txt
>  - *.bat scripts shouldn't be installed on UNIX systems
>  - use CMAKE_INSTALL_* consistently to install files in the
>    correct places
wouldn't it make more sense to write the specific reason for the commits
*into* the specific commit?
This email with your explanation why you have done all that work will go
down under in the typical noise of the mailing list and nobody but you
will later know why the single commit was made.

-- 
Regards
Carsten Schoenert


Follow ups

References