kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 05/11/2017 à 12:04, Oliver Walters a écrit :
> I think that is the desired behaviour, though? Once in the board, the can edit the layers
> individually anyway.

I missed something, I did not notice it was possible the layers individually from the board editor.
(However, when trying that, I had a Pcbnew crash, but I am not able to reproduce it.)

An other UI issue I missed is the fact (after your patch is applied) when you try to select a item
inside a footprint (pad, field) in the board editor, a disambiguated menu is displayed showing twice
the same item, although only one exists.
It also happens in fpeditor when trying to select a keepout.

> 
> On Sun, Nov 5, 2017 at 9:57 PM, jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>> wrote:
> 
>     Le 05/11/2017 à 11:48, Oliver Walters a écrit :
>     > How best to store the layer information then? The way I was doing it previously was:
>     >
>     > -  F.Cu
>     > - *.Inner.Cu
>     > - B.Cu
>     >
>     > Is this sufficient?
> 
>     Yes, this is sufficient, when a keepout is inside a footprint.
> 
>     The issue was the fact *.Inner.Cu information was lost with a 2 layers board, when saving this
>     board, or exporting to the fp editor.
> 
> 
>     >
>     > On Sun, Nov 5, 2017 at 9:41 PM, jp charras <jp.charras@xxxxxxxxxx
>     <mailto:jp.charras@xxxxxxxxxx> <mailto:jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>>> wrote:
>     >
>     >     Le 05/11/2017 à 11:12, Oliver Walters a écrit :
>     >     > JP,
>     >     >
>     >     > Did you have any other things you want me to address here?
>     >     >
>     >     > Cheers,
>     >     > Oliver
>     >     >
>     >
>     >     Yes: I did not make a lot of tests, but I found some issues (tested on W7 32 bits):
>     >
>     >     First, Pcbnew crashed after editing (after adding a keepout) a footprint on a board in
>     this case:
>     >     - select and edit a footprint (Ctrl+E) in fp editor: just add a keepout, and save it on
>     the board.
>     >     - then reselect and edit this footprint a second time in fp editor: Pcbnew crashes.
>     >
>     >     Other issues in fp editor:
>     >     - modifying a keepout cannot be undone.
>     >     - The keepout layers are no selectable: I am thinking the options: Top layer, bottom layer and
>     >     internal layers (existing in the first version) is really better.
>     >     Just this is the way these layers are managed in board editor and stored in file that was
>     not good
>     >     (especially when a board has only 2 layers: the internal layers setting was lost).
>     >
>     >     As a side effect: the look of the keepout layer dialog is not very good after resized:
>     >     - Create a keepout on a board: the dialog shows the layers list.
>     >     - After that, create a keepout in the fpeditor: the layers list is not shown, but its area
>     exists,
>     >     and the look of the dialog is not good.
>     >
>     >
>     >     --
>     >     Jean-Pierre CHARRAS
>     >
>     >
> 
> 
>     --
>     Jean-Pierre CHARRAS
> 
> 


-- 
Jean-Pierre CHARRAS