kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #31366
Re: [PATCH] Replace .wrl files with .step on export (fixes lp:1710796)
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Mon, 6 Nov 2017 13:17:33 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<CAMfgvU8ks+5TZ5aW95r7+HF3C3+X-QMd2Fe00x0=WH9kZo80ug@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
Hi Oliver,
If I may suggest one thing, then I would turn:
+ if( ext == "wrl" || ext == "WRL" || ext == "Wrl" )
+ return FMT_WRL;
into:
+ if( ext.Lower() == "wrl" )
+ return FMT_WRL;
Apart from that, the patch seems fine just by reading the contents. No
need to send another patch, I think it can fixed by the committer. I
have not merged it only because I have not had a chance to build and
test it *yet*. Thank you very much for fixing another bug!
Cheers,
Orson
On 11/04/2017 01:47 PM, Oliver Walters wrote:
> The attached patch implements the feature suggested here :
> https://bugs.launchpad.net/kicad/+bug/1710796
>
> Problem:
>
> .wrl files are specified as default but these don't export to MCAD.
>
> Solution:
>
> On STEP export, wrl files are replaced with their step counterparts (if
> such models exist).
>
> This is essentially what Maurice's famous StepUP tool does.
>
> Turns out it was a pretty simple fix :)
>
> Regards,
> Oliver
Attachment:
signature.asc
Description: OpenPGP digital signature
Follow ups
References
