kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #31404
Re: [PATCH] Replace .wrl files with .step on export (fixes lp:1710796)
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Suminski <maciej.suminski@xxxxxxx>
-
Date:
Tue, 7 Nov 2017 00:02:40 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<9e28a0b1-3241-8ef1-177f-f0f75c3b44f5@gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
Hi Wayne,
I think it only affects the STEP exporter (kicad2step executable), which
cannot handle WRL models at all. With the patch applied, the exporter
looks for a model with the same file name, but .step extension. In case
there one is found - it is during the STEP export. I believe there is
only an extra feature, no functionality removed/broken.
Regards,
Orson
On 11/06/2017 05:07 PM, Wayne Stambaugh wrote:
> If I'm reading this patch correctly, exported wrl files will always have
> step file references in them even when they are found. If that is the
> case, then I am opposed to this change. AFAIK, opening the wrl board
> file will fail with the embedded step file links. It would make more
> sense to me that kicad2step would attempt to substitute the wrl file
> links withe step files when converting wrl to step.
>
> On 11/4/2017 8:47 AM, Oliver Walters wrote:
>> The attached patch implements the feature suggested here
>> : https://bugs.launchpad.net/kicad/+bug/1710796
>>
>> Problem:
>>
>> .wrl files are specified as default but these don't export to MCAD.
>>
>> Solution:
>>
>> On STEP export, wrl files are replaced with their step counterparts (if
>> such models exist).
>>
>> This is essentially what Maurice's famous StepUP tool does.
>>
>> Turns out it was a pretty simple fix :)
>>
>> Regards,
>> Oliver
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References