← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Replace .wrl files with .step on export (fixes lp:1710796)

 

Apparently I did not read the patch correctly.

On 11/6/2017 3:30 PM, Oliver Walters wrote:
> Wayne,
> 
> 
>  /It would make more//
> sense to me that kicad2step would attempt to substitute the wrl file
> links withe step files when converting wrl to step./
> 
> This is exactly what it does. I'm not sure what you mean with embedded
> step file references. 
> 
> On 7 Nov 2017 03:07, "Wayne Stambaugh" <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     If I'm reading this patch correctly, exported wrl files will always have
>     step file references in them even when they are found.  If that is the
>     case, then I am opposed to this change.  AFAIK, opening the wrl board
>     file will fail with the embedded step file links.  It would make more
>     sense to me that kicad2step would attempt to substitute the wrl file
>     links withe step files when converting wrl to step.
> 
>     On 11/4/2017 8:47 AM, Oliver Walters wrote:
>     > The attached patch implements the feature suggested here
>     > : https://bugs.launchpad.net/kicad/+bug/1710796
>     <https://bugs.launchpad.net/kicad/+bug/1710796>
>     >
>     > Problem:
>     >
>     > .wrl files are specified as default but these don't export to MCAD. 
>     >
>     > Solution:
>     >
>     > On STEP export, wrl files are replaced with their step
>     counterparts (if
>     > such models exist).
>     >
>     > This is essentially what Maurice's famous StepUP tool does.
>     >
>     > Turns out it was a pretty simple fix :)
>     >
>     > Regards,
>     > Oliver
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
> 



References