← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Replace .wrl files with .step on export (fixes lp:1710796)

 

Hey Orson,

I've got it now.  Go ahead and commit it if you have it ready to go.  If
not, I will do it in the next day or so.

Cheers,

Wayne

On 11/6/2017 6:02 PM, Maciej Suminski wrote:
> Hi Wayne,
> 
> I think it only affects the STEP exporter (kicad2step executable), which
> cannot handle WRL models at all. With the patch applied, the exporter
> looks for a model with the same file name, but .step extension. In case
> there one is found - it is during the STEP export. I believe there is
> only an extra feature, no functionality removed/broken.
> 
> Regards,
> Orson
> 
> On 11/06/2017 05:07 PM, Wayne Stambaugh wrote:
>> If I'm reading this patch correctly, exported wrl files will always have
>> step file references in them even when they are found.  If that is the
>> case, then I am opposed to this change.  AFAIK, opening the wrl board
>> file will fail with the embedded step file links.  It would make more
>> sense to me that kicad2step would attempt to substitute the wrl file
>> links withe step files when converting wrl to step.
>>
>> On 11/4/2017 8:47 AM, Oliver Walters wrote:
>>> The attached patch implements the feature suggested here
>>> : https://bugs.launchpad.net/kicad/+bug/1710796
>>>
>>> Problem:
>>>
>>> .wrl files are specified as default but these don't export to MCAD. 
>>>
>>> Solution:
>>>
>>> On STEP export, wrl files are replaced with their step counterparts (if
>>> such models exist).
>>>
>>> This is essentially what Maurice's famous StepUP tool does.
>>>
>>> Turns out it was a pretty simple fix :)
>>>
>>> Regards,
>>> Oliver
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



Follow ups

References