kicad-developers team mailing list archive

[Oliver Walters <oliver.henry.walters@xxxxxxxxx>]

Wayne,

That's a fair point, I was considering adding each combination but decided
against it. I couldn't find a sensible way either, without traversing the
entire directory.

On Wed, Nov 8, 2017 at 12:23 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> Oliver,
>
> I'm fine with your patch but as a project we need to be more careful
> about file extensions on case sensitive platforms.  There is already a
> bug report about this for the GTK+ file dialog.  Your list of step and
> iges file extensions is not complete.  If someone uses "Iges", "igeS",
> ... no matter how unlikely it is, it will fail to find a legitimate
> file.  I'll commit this as is but we definitely need to rethink case
> sensitive file extension support.  Having a list of every possible
> combination of upper and lower case letters for a single file extension
> is ugly.  Perhaps regular expressions would be helpful in this case.  I
> didn't see anything in wxFileName or wxDir that would allow us to do
> this but maybe there is some undocumented way to handle this.  We cannot
> be the first project to encounter this issue.
>
> Cheers,
>
> Wayne
>
> On 11/7/2017 8:03 AM, Oliver Walters wrote:
> > Following on from the STEP / WRL substitution patch earlier today:
> >
> > Nick suggested that IGES should be searched for if there are no STEP
> > models found.
> >
> > This simple patch does that. If no step models are found, it then
> > searches for iges.
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>