kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

This is different than fixing the GTK+ file dialog extension issue.  The
code Oliver fixed doesn't call wxFileDialog.  I am actually working on
the GTK+ file dialog extension fix right now.  I may get it merged this
evening if all goes well (please don't hold your breath on that).

On 11/7/2017 11:38 AM, Eldar Khayrullin wrote:
> Hello, Wayne.
> As I said early in https://bugs.launchpad.net/kicad/+bug/1720542
> extension like .DXF or .dxf are more common (>90%) than other (man types).
> Maybe we should use this common cases?
> 
> В Вторник, 7 ноя. 2017 в 4:23 П. П., Wayne Stambaugh
> <stambaughw@xxxxxxxxx> написал:
>> Oliver, I'm fine with your patch but as a project we need to be more
>> careful about file extensions on case sensitive platforms. There is
>> already a bug report about this for the GTK+ file dialog. Your list of
>> step and iges file extensions is not complete. If someone uses "Iges",
>> "igeS", ... no matter how unlikely it is, it will fail to find a
>> legitimate file. I'll commit this as is but we definitely need to
>> rethink case sensitive file extension support. Having a list of every
>> possible combination of upper and lower case letters for a single file
>> extension is ugly. Perhaps regular expressions would be helpful in
>> this case. I didn't see anything in wxFileName or wxDir that would
>> allow us to do this but maybe there is some undocumented way to handle
>> this. We cannot be the first project to encounter this issue. Cheers,
>> Wayne On 11/7/2017 8:03 AM, Oliver Walters wrote:
>>
>>     Following on from the STEP / WRL substitution patch earlier today:
>>     Nick suggested that IGES should be searched for if there are no
>>     STEP models found. This simple patch does that. If no step models
>>     are found, it then searches for iges.
>>     _______________________________________________ Mailing list:
>>     https://launchpad.net/~kicad-developers Post to :
>>     kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx> Unsubscribe :
>>     https://launchpad.net/~kicad-developers More help :
>>     https://help.launchpad.net/ListHelp 
>>
>> _______________________________________________ Mailing list:
>> https://launchpad.net/~kicad-developers Post to :
>> kicad-developers@xxxxxxxxxxxxxxxxxxx
>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx> Unsubscribe :
>> https://launchpad.net/~kicad-developers More help :
>> https://help.launchpad.net/ListHelp