kicad-developers team mailing list archive

[Maciej Suminski <maciej.suminski@xxxxxxx>]

Hi Marvin,

On 11/09/2017 08:12 PM, Marvin Schmidt wrote:
> Hey Orson,
> 
> I actually didn't skip any patch, #8 ("Remove orphaned code files")
> should is there:
> https://lists.launchpad.net/kicad-developers/msg31304.html

Strange, I have never received this message, but now I am glad that I
have asked.

> I rebased my patches and pushed them to my Github repository, I think
> it's easier for both of us that way :-)
> 
> Please pull from https://github.com/marv/kicad-dev/tree/housekeeping

Surely it is much easier. I have just pushed your changes to the master
branch. Thank you!

Regards,
Orson

> Best regards,
> Marvin
> 
> On Sun, Nov 05, 2017 at 10:21:41PM +0100, Maciej Suminski wrote:
>> Hi Marvin,
>>
>> Have you skipped patch 0008 intentionally? Some of the changes from this
>> set do not apply cleanly, would you rebase them?
>>
>> Regards,
>> Orson
>>
>> On 11/02/2017 09:58 PM, Marvin Schmidt wrote:
>>> Just a set of small code cleanups to fix a bunch of warnings
>>> and remove dead code.
>>> Other than that the 'build:' commits avoid/remove/fix the
>>> installation of certain files:
>>>  - it doesn't make much sense to install the INSTALL.txt
>>>  - *.bat scripts shouldn't be installed on UNIX systems
>>>  - use CMAKE_INSTALL_* consistently to install files in the
>>>    correct places
>>>
>>> Marvin Schmidt (12):
>>>   build: Don't install INSTALL.txt
>>>   build: Use CMAKE_INSTALL_DATADIR
>>>   build: Remove dead code
>>>   build: Don't install *.bat scripts on Unix
>>>   Fix a typo
>>>   Remove unused #define
>>>   Remove some dead code
>>>   Remove orphaned code files
>>>   Remove some extra semicolons
>>>   Remove duplicate #include
>>>   Remove some else-after-return's
>>>   Use std::remove_pointer instead of own implementation (NFC)
>>>
>>>  3d-viewer/3d_cache/dialogs/3d_cache_dialogs.h   |   2 +-
>>>  3d-viewer/3d_cache/sg/sg_helpers.cpp            |   2 +-
>>>  3d-viewer/3d_cache/sg/sg_helpers.h              |   2 +-
>>>  3d-viewer/3d_cache/sg/sg_node.h                 |   2 +-
>>>  3d-viewer/3d_cache/str_rsort.h                  |   2 +-
>>>  3d-viewer/3d_canvas/eda_3d_canvas.h             |   2 +-
>>>  3d-viewer/3d_model_viewer/c3d_model_viewer.h    |   2 +-
>>>  3d-viewer/3d_viewer/eda_3d_viewer.h             |   2 +-
>>>  CMakeLists.txt                                  |  17 +--
>>>  common/bitmap.cpp                               |   4 +-
>>>  common/class_undoredo_container.cpp             |  39 ++++---
>>>  common/eagle_parser.cpp                         |   4 +-
>>>  common/single_top.cpp                           |   2 +-
>>>  common/view/view.cpp                            |   2 +-
>>>  common/widgets/mathplot.cpp                     |   6 +-
>>>  common/wxunittext.cpp                           | 142 -----------------------
>>>  eeschema/dialogs/dialog_bom.cpp                 |   2 +-
>>>  eeschema/pin_shape.cpp                          |   2 +-
>>>  eeschema/plot_schematic_HPGL.cpp                |   2 +-
>>>  eeschema/sch_io_mgr.cpp                         |   2 +-
>>>  eeschema/sch_io_mgr.h                           |   2 +-
>>>  eeschema/sch_item_struct.cpp                    |   7 --
>>>  eeschema/sch_item_struct.h                      |   4 -
>>>  eeschema/sch_screen.cpp                         |   3 -
>>>  gerbview/class_gerber_draw_item.h               |   2 +-
>>>  gerbview/class_gerbview_layer_widget.cpp        |   2 +-
>>>  include/class_draw_panel_gal.h                  |   2 +-
>>>  include/core/typeinfo.h                         |  22 +---
>>>  include/geometry/rtree.h                        |   2 +-
>>>  include/plugins/3dapi/ifsg_api.h                |   2 +-
>>>  include/plugins/3dapi/sg_types.h                |   2 +-
>>>  include/system/libcontext.h                     |   4 +-
>>>  include/tool/tool_base.h                        |   2 +-
>>>  include/tool/tool_dispatcher.h                  |   2 +-
>>>  include/ttl/halfedge/hetraits.h                 |   2 +-
>>>  include/ttl/halfedge/hetriang.h                 |   4 +-
>>>  include/wxunittext.h                            | 144 ------------------------
>>>  kicad/kicad.cpp                                 |   2 +-
>>>  pcb_calculator/UnitSelector.cpp                 |  10 +-
>>>  pcbnew/class_drawsegment.cpp                    |   2 +-
>>>  pcbnew/class_module.h                           |   2 +-
>>>  pcbnew/class_netclass.h                         |   2 +-
>>>  pcbnew/class_pad.h                              |   2 +-
>>>  pcbnew/class_zone.cpp                           |   2 +-
>>>  pcbnew/class_zone_settings.cpp                  |   2 +-
>>>  pcbnew/dialogs/dialog_footprint_wizard_list.cpp |   6 +-
>>>  pcbnew/exporters/export_gencad.cpp              |   4 +-
>>>  pcbnew/exporters/export_vrml.cpp                |   2 +-
>>>  pcbnew/moduleframe.cpp                          |   2 +-
>>>  pcbnew/router/pns_kicad_iface.h                 |   2 +-
>>>  pcbnew/router/pns_router.h                      |   2 +-
>>>  pcbnew/tools/tool_event_utils.h                 |   2 +-
>>>  pcbnew/tools/zone_create_helper.cpp             |   2 +-
>>>  plugins/3d/idf/s3d_plugin_idf.cpp               |   2 +-
>>>  plugins/3d/vrml/wrlfacet.cpp                    |   2 +-
>>>  plugins/3d/vrml/x3d/x3d_ops.h                   |   2 +-
>>>  polygon/clipper.cpp                             |   2 +-
>>>  57 files changed, 89 insertions(+), 413 deletions(-)
>>>  delete mode 100644 common/wxunittext.cpp
>>>  delete mode 100644 include/wxunittext.h
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>