← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix for 3D model offset

 

Wayne,

I had not yet made any changes to the file parser. Have you done this
according to your new file-version approach? Or do you want me to submit a
further patch implementing that?

On 12 Nov 2017 07:16, "Wayne Stambaugh" <stambaughw@xxxxxxxxx> wrote:

> Oliver,
>
> I committed your patch to the KiCad development branch.
>
> Thanks,
>
> Wayne
>
> On 11/08/2017 05:05 AM, Oliver Walters wrote:
> > Attached is a patch that fixes the problems I found in my 3D model array
> > investigation. As discussion on that is stalled for now, this patch
> > simply fixes the model offset issues.
> >
> > 1. Display offset units in 3D preview window
> >
> > - Offset units are displayed (either inches or mm)
> >
> > 2. Fix offset in 3D rendering
> >
> > - It appears that the internal units for 3D model offset (mm) were being
> > multiplied by 25.4 incorrectly
> > - Fixed rendering in OGL and Raytracing
> >
> > 3. Fix offset in 3D export
> >
> > - VRML export
> > - STEP export
> >
> > Oliver
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References