kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

Hi Seth

This feature sounds great and something that I have wished for for a
long time. Thanks.

I just attempted to apply your patches, but the first does not apply
on d98fc85a8, which should be the current HEAD of upstream master
unless I did something stupid locally.

Nick

2017-11-13 19:35 GMT+01.00, Seth Hillbrand <seth.hillbrand@xxxxxxxxx>:
> Thanks JP for catching!
>
> I'm attaching the revised patchset with plot functionality implemented.  In
> digging through this, I also found a bug/typo that prevented HPGL from
> outputting any dashed lines.  This is now corrected.
>
> Additionally, the DXF plot had suppressed all non-solid lines, so I added
> the export functionality there for our 4 line types.
>
> I also bumped the eeschema version.
>
> Best-
> Seth
>
> On Sat, Nov 11, 2017 at 7:36 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
>
>> On 11/11/2017 03:07 AM, jp charras wrote:
>> > Le 11/11/2017 à 05:51, Seth Hillbrand a écrit :
>> >> Wayne-
>> >>
>> >> Thank you for taking the time to look at this patch.  I recognize that
>> you and the other devs have a
>> >> lot on your plate, so I appreciate the constructive feedback. I'll
>> approach the list with a sketch
>> >> in the future for large patches.
>> >>
>> >> I've addressed the coding policy violations and dialog alignment
>> >> issues
>> in the attached patch.
>> >
>> > Hi Seth,
>> > Are you sure the plot functions can handle this line style parameter?
>>
>> Good catch JP.  Seth, this needs to be addressed for all of the plog and
>> print functions otherwise there will be a bunch of bug reports.  You may
>> have a substantial amount of additional work in order to fix all of this.
>>
>> >
>> >>
>> >> On Fri, Nov 10, 2017 at 4:40 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
>> >> <mailto:stambaughw@xxxxxxxxx>> wrote:
>> >>
>> >>
>> >>     Just because you found a work around in the parser does not mean
>> your
>> >>     change does not constitute a file format change.  When someone
>> loads a
>> >>     schematic in an earlier version of eeschema and saves the
>> schematic, all
>> >>     of this information will be lost.  That smells like a file format
>> change
>> >>     to me.  If I were going to accept this patch, it would require a
>> file
>> >>     version bump.  I would also prefer that you didn't use tabs in the
>> file
>> >>     writer.  Did you try loading this with stable version 4 which uses
>> the
>> >>     old parser?
>> >>
>> >>
>> >> ​Agreed.  This is a format change and I understand the preference even
>> if it is backwards
>> >> compatible.  I have verified that schematics do open as expected in
>> 4.0.5 and 4.0.7 under Linux and
>> >> Mac.  Of course, 4.0.5 and 4.0.7 expect file format version '2' and
>> master currently writes version
>> >> '3', so there is the standard warning message about possible
>> >> problems.​
>>  But formatted lines revert
>> >> to standard graphic lines as expected.
>> >>
>> >> On the tabs issue, I'm afraid I'm not clear which tabs you are
>> referencing.  In the current
>> >> schematic file format, the wire data lines are indented with a tab but
>> that has been in place for
>> >> some time (at least since version 2).  But maybe I am misinterpreting
>> your comment here?
>> >>
>> >> ​Best-
>> >> Seth​
>> >
>> >
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>