kicad-developers team mailing list archive

[easyw <easyw@xxxxxxxxxxxx>]

Hi Orson,

> I think you write this assuming the v5 file format will have 
> m_requiredVersion set to 5. If I recall correctly, we have decided to 
> use dates for file versioning and this method will be kept for v5 and 
> later versions, so we should be safe here.

if this the new Version policy I missed, then this is fine.

Thanks for your clarification,

Maurice


On 11/15/2017 3:40 PM, Maciej Suminski wrote:
> Hi Maurice,
>
> On 15/11/2017 1:21 PM, easyw wrote:
> > Just a clarification request:
> >
> > Kicad Stable has version assigned to 4
> > Previous stable had version assigned to 3
> >
> > I imagine that next stable would have version assigned to 5...
> > Am I right in supposing the next numbering release?
> >
> > If I'm fine, with the proposed patch the new stable release, if assigned
> > coherently to actual releases numbering, will fail the check that is in
> > this patch; the new parser will then mess up all 3D offsets each time
> > the board will be saved/displayed...
> >
> > > +            if(m_requiredVersion < 20171114UL)
>
> I think you write this assuming the v5 file format will have 
> m_requiredVersion set to 5. If I recall correctly, we have decided to 
> use dates for file versioning and this method will be kept for v5 and 
> later versions, so we should be safe here.
>
> > As I already stated the actual situation has no problem in displaying
> > the correct offset in 3D viewer and the exporters are fine...
> > The only 'issue', if we can say this is an issue, is that the offset is
> > assigned to deci-mils and not millimeters inside the footprint...
> >
> > This is going to open big headaches for which enhancement?
> > My 2 cents
>
> The solution Oliver has proposed looks solid to me, I do not see any 
> potential headache. The patch has a very noble goal of fixing one of the 
> biggest KiCad sins - incoherence. I think the reason is good enough to 
> commit the patch.
>
> Regards,
> Orson
>
> > Maurice
> >
> >
> >
> > On 11/14/2017 10:55 AM, Oliver Walters wrote:
> > > Wayne,
> > >
> > > Please find attached updated patch set. If an old version is detected,
> > > inches are converted to mm.
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp