kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Oliver,

Please send me the latest patch(es) when you get a chance so I can get
this merged.  I cannot find it (them) in my inbox.  I must have deleted
the email by accident.

Cheers,

Wayne

On 11/18/2017 8:39 PM, Oliver Walters wrote:
> Wayne,
> 
> Any further issues to address here? :)
> 
> On 14 Nov 2017 20:55, "Oliver Walters" <oliver.henry.walters@xxxxxxxxx
> <mailto:oliver.henry.walters@xxxxxxxxx>> wrote:
> 
>     Wayne,
> 
>     Please find attached updated patch set. If an old version is
>     detected, inches are converted to mm.
> 
>     On Tue, Nov 14, 2017 at 9:33 AM, Nick Østergaard <oe.nick@xxxxxxxxx
>     <mailto:oe.nick@xxxxxxxxx>> wrote:
> 
>         Just to mention it, I think this quirk needs to be put in the
>         release
>         notes for 5.0.0 if that would be the case, or at least
>         documented as a
>         note in the docs.
> 
>         2017-11-13 18:10 GMT+01.00, Wayne Stambaugh
>         <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>:
>         > On 11/12/2017 6:12 AM, Oliver Walters wrote:
>         >> Wayne,
>         >>
>         >> Another potential spanner in the works - the footprint files
>         do not
>         >> store the file version information. (should they?)
>         >
>         > I would rather not.  Otherwise there would be a footprint
>         version in
>         > every footprint embedded in the schematic and could lead to
>         some ugly
>         > parser code.  At some point we may need to revisit this but
>         not now.
>         >
>         > This is not a big issue because the only effects the
>         footprints embedded
>         > in the board.  Users with custom footprint libraries that
>         contain 3D
>         > model offsets will just have to fix the offsets.  I'm guessing
>         this is a
>         > fairly small number of users.
>         >
>         >>
>         >> Thus, footprint files cannot be parsed differently based on
>         their file
>         >> version. Changing "at" between mm and inches will work for
>         the pcb but
>         >> not for the individual footprint files
>         >>
>         >> On Sun, Nov 12, 2017 at 7:47 AM, Wayne Stambaugh
>         <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>         >> <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>
>         wrote:
>         >>
>         >>     I misunderstood the intention of this patch.  I though it
>         had nothing
>         >> to
>         >>     do with the units change patch.  I will revert it. 
>         Please send me the
>         >>     file format change patch when you get a chance and I
>         merge them both
>         >> at
>         >>     the same time.  Sorry about the mix up.
>         >>
>         >>     On 11/11/2017 03:34 PM, Oliver Walters wrote:
>         >>     > Wayne,
>         >>     >
>         >>     > I had not yet made any changes to the file parser. Have
>         you done
>         >> this
>         >>     > according to your new file-version approach? Or do you
>         want me to
>         >> submit
>         >>     > a further patch implementing that?
>         >>     >
>         >>     > On 12 Nov 2017 07:16, "Wayne Stambaugh"
>         <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>         >> <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
>         >>     > <mailto:stambaughw@xxxxxxxxx
>         <mailto:stambaughw@xxxxxxxxx> <mailto:stambaughw@xxxxxxxxx
>         <mailto:stambaughw@xxxxxxxxx>>>> wrote:
>         >>     >
>         >>     >     Oliver,
>         >>     >
>         >>     >     I committed your patch to the KiCad development branch.
>         >>     >
>         >>     >     Thanks,
>         >>     >
>         >>     >     Wayne
>         >>     >
>         >>     >     On 11/08/2017 05:05 AM, Oliver Walters wrote:
>         >>     >     > Attached is a patch that fixes the problems I
>         found in my 3D
>         >>     model
>         >>     >     array
>         >>     >     > investigation. As discussion on that is stalled
>         for now,
>         >>     this patch
>         >>     >     > simply fixes the model offset issues.
>         >>     >     >
>         >>     >     > 1. Display offset units in 3D preview window
>         >>     >     >
>         >>     >     > - Offset units are displayed (either inches or mm)
>         >>     >     >
>         >>     >     > 2. Fix offset in 3D rendering
>         >>     >     >
>         >>     >     > - It appears that the internal units for 3D model
>         offset
>         >>     (mm) were
>         >>     >     being
>         >>     >     > multiplied by 25.4 incorrectly
>         >>     >     > - Fixed rendering in OGL and Raytracing
>         >>     >     >
>         >>     >     > 3. Fix offset in 3D export
>         >>     >     >
>         >>     >     > - VRML export
>         >>     >     > - STEP export
>         >>     >     >
>         >>     >     > Oliver
>         >>     >     >
>         >>     >     >
>         >>     >     > _______________________________________________
>         >>     >     > Mailing list:
>         https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>
>         >>     >     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>>
>         >>     >     > Post to     :
>         kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         >>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>         >>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         >>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>         >>     >     > Unsubscribe :
>         https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>
>         >>     >     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>>
>         >>     >     > More help   : https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>
>         >>     <https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>>
>         >>     >     <https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>
>         >>     <https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>>>
>         >>     >     >
>         >>     >
>         >>     >     _______________________________________________
>         >>     >     Mailing list:
>         https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>
>         >>     >     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>>
>         >>     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         >>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>         >>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         >>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>         >>     >     Unsubscribe :
>         https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>
>         >>     >     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         >>     <https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>>>
>         >>     >     More help   : https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>
>         >>     <https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>>
>         >>     >     <https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>
>         >>     <https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>>>
>         >>     >
>         >>
>         >>
>         >
>         > _______________________________________________
>         > Mailing list: https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         > Unsubscribe : https://launchpad.net/~kicad-developers
>         <https://launchpad.net/~kicad-developers>
>         > More help   : https://help.launchpad.net/ListHelp
>         <https://help.launchpad.net/ListHelp>
>         >
> 
>