← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix for 3D model offset

 

I understand this will break "forwards compatibility" if opening a v5 file from v4.
and this break will be also 'silent'
Sometimes such changes are unavoidable.point of views ... as I already pointed out I don't remember how many
times, this changing is started for a wrong assumption: that 3D viewer and exporters would have failed in managing the 3D offsets... which is wrong... this wrong assumption started a misunderstanding of the issue itself. Moreover the internal representation of a data that was just simple correctly managed is a real formal issue and not a user issue... So, IMO, this was something absolutely avoidable instead of something unavoidable...
but this is obviously my point of view...

On 11/22/2017 11:16 PM, Oliver Walters wrote:
I understand this will break "forwards compatibility" if opening a v5 file from v4. Sometimes such changes are unavoidable.

On Thu, Nov 23, 2017 at 8:44 AM, easyw <easyw@xxxxxxxxxxxx <mailto:easyw@xxxxxxxxxxxx>> wrote:

    This option is in fact a smooth transition for footprints...
    but it will break the readability of new boards by previous release
    of kicad... no way back to previous releases, even to be just read...
    Which is better then?
    Library stuff are quite delicate to be touched IMO...

    On 11/22/2017 10:23 PM, Oliver Walters wrote:

        Wayne I still have an issue with silently breaking files. Using
        an "offset" parameter (but reading "at" for compatibility) does
        not break anyone's models and there is absolutely no confusion
        about which is mm and which is inches. Incidentally I think
        "offset" is a better name, it implies relative position rather
        than absolute (but that's neither here nor there).

        On Thu, Nov 23, 2017 at 7:55 AM, Marcos Chaparro
        <nitrousnrg@xxxxxxxxx <mailto:nitrousnrg@xxxxxxxxx>
        <mailto:nitrousnrg@xxxxxxxxx <mailto:nitrousnrg@xxxxxxxxx>>> wrote:

             On Wed, Nov 22, 2017 at 11:59 AM, Wayne Stambaugh
             <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
        <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:

                 Yes, it is a change that will break some users 3D models
                 but I think the long term benefit outweighs the short term
                 annoyance.


             It will break most of my boards. I won't complain because I
             appreciate the effort and I welcome *every* improvement, but be
             prepared for some very rough comments out there.

             _______________________________________________
             Mailing list: https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
             <https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>>
             Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
             <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
             Unsubscribe : https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
             <https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>>
             More help   : https://help.launchpad.net/ListHelp
        <https://help.launchpad.net/ListHelp>
             <https://help.launchpad.net/ListHelp
        <https://help.launchpad.net/ListHelp>>




        _______________________________________________
        Mailing list: https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
        <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
        Unsubscribe : https://launchpad.net/~kicad-developers
        <https://launchpad.net/~kicad-developers>
        More help   : https://help.launchpad.net/ListHelp
        <https://help.launchpad.net/ListHelp>


    _______________________________________________
    Mailing list: https://launchpad.net/~kicad-developers
    <https://launchpad.net/~kicad-developers>
    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
    Unsubscribe : https://launchpad.net/~kicad-developers
    <https://launchpad.net/~kicad-developers>
    More help   : https://help.launchpad.net/ListHelp
    <https://help.launchpad.net/ListHelp>




References