kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

With an upcoming 5.0 I'm not sure how necessary it is to re-release
4.0.7 - I just want to make sure the same mistake doesn't get made for
5.0...

On Sun, Nov 26, 2017 at 11:03:48PM +0000, Wayne Stambaugh wrote:
> 4.0.7-2 seems reasonable if the previous macos version was 4.0.7-1.
> 
> On 11/26/2017 05:25 PM, Adam Wolf wrote:
> > 1) I'll take a look at the script, but I suspect Nick is correct.
> > 
> > 2) What version number should I release this 4.0.7 as? 4.0.7-2?
> > 
> > Adam Wolf
> > 
> > On Sun, Nov 26, 2017 at 3:35 PM, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> >> It is because of what happened in:
> >> [Kicad-developers] Yet another 4.0.7 release bug.
> >> https://lists.launchpad.net/kicad-developers/msg30192.html
> >>
> >> I suspect that the script for the OSX build did not consider that tags could
> >> move. Which I think could happen like this:
> >>
> >> A tag will get pulled down when you pull normally. But if it changes
> >> upstream you need to fetch with the --tags option
> >> to sync it.
> >>
> >> 2017-11-26 20:12 GMT+01:00 Chris Pavlina <pavlina.chris@xxxxxxxxx>:
> >>>
> >>> Okay people, wtf happened here.
> >>>
> >>> Helping someone on IRC figure out a PDF export bug on 4.0.7, when I
> >>> realized this:
> >>>
> >>> https://misc.c4757p.com/pastes/0AOyojEiEE0V.txt
> >>>
> >>> ^ "Tag stable release" is commit 631f6d5, on July 14. The ACTUAL 4.0.7
> >>> tag is on 9f35e38, four commits later on August 1.
> >>>
> >>> Guess which one got released?
> >>>
> >>> Yup, we released the wrong commit for 4.0.7. The older one, missing
> >>> several bug fixes. How did we manage to release something that wasn't
> >>> actually tagged as 4.0.7? Doesn't the release build process involve
> >>> something like "git checkout 4.0.7"? Help me understand what went wrong
> >>> here...
> >>>
> >>> I'm still trying to figure out how a commit titled "tag stable release
> >>> 4.0.7" and the actual 4.0.7 tag do not point at the same place, let
> >>> alone how the release build process does not actually directly check out
> >>> the 4.0.7 tag.
> >>>
> >>> --
> >>> Chris
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp