← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Reset tool transitions even when already active (Fixes lp:1733224)

 

Possibly also related to this: https://bugs.launchpad.net/kicad/+bug/1678575
The shortcut actions are not properly verified against present state
conditions under which they should be allowed to operate under before the
actions are triggered.

On Sun, Nov 26, 2017 at 5:23 PM, Jon Evans <jon@xxxxxxxxxxxxx> wrote:

> Tom, you might want to take a look at this one.
>
> I was looking into this bug and noticed some odd behavior and I'm not
> quite sure what the intended behavior is: https://bugs.launchpad.net/
> kicad/+bug/1733224
>
> When EDIT_TOOL::Main() is activated by move hotkey, transitions are reset
> and other edit tool actions can be issued (for example, Rotate).  But you
> can also hit M again, which sends another event to start the Main(), and
> since the tool is already active, transitions are not reset.
>
> The attached patch changes this, and seems to work fine, but I'm not sure
> if there is some reason why it was not done this way.
>
> Thanks,
> Jon
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Remember The Past, Live The Present, Change The Future
Those who look only to the past or the present are certain to miss the
future [JFK]

kandrey89@xxxxxxxxx
Live Long and Prosper,
Andrey

References