← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Reset tool transitions even when already active (Fixes lp:1733224)

 

Thank you Jon, I think your patch makes sense. I have just pushed it to
the master branch.

Regards,
Orson

On 11/27/2017 02:23 AM, Jon Evans wrote:
> Tom, you might want to take a look at this one.
> 
> I was looking into this bug and noticed some odd behavior and I'm not quite
> sure what the intended behavior is:
> https://bugs.launchpad.net/kicad/+bug/1733224
> 
> When EDIT_TOOL::Main() is activated by move hotkey, transitions are reset
> and other edit tool actions can be issued (for example, Rotate).  But you
> can also hit M again, which sends another event to start the Main(), and
> since the tool is already active, transitions are not reset.
> 
> The attached patch changes this, and seems to work fine, but I'm not sure
> if there is some reason why it was not done this way.
> 
> Thanks,
> Jon
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References