← Back to team overview

kicad-developers team mailing list archive

Re: Consistency in messages

 

On 11/29/2017 05:04 PM, Chris Pavlina wrote:
> On Wed, Nov 29, 2017 at 03:56:20PM -0500, Wayne Stambaugh wrote:
>> I typically use '%s' mainly because it's easier than escaping the double
>> quote but I'm not opposed to "%s".  <%s> should be avoided because some
>> text controls interpret the <> as html tags.  I thought we got ride of
>> most if not all of the <%s> occurrences but apparently not.
> 
> Frankly if you're putting arbitrary strings into something that
> interprets the input as HTML, you should be running through an escape
> function first _anyway_, and that should automatically replace < and >
> with &lt; and &gt; ...

I agree in principal but if memory serves, there are control differences
between platforms which would make implementing this less than trivial.

> 
>>
>> On 11/29/2017 3:26 PM, Simon Richter wrote:
>>> Hi,
>>>
>>> we don't seem to have a consistent convention on quoting in messages
>>> shown to the user, and thus we have all three of
>>>
>>>     '%s'
>>>     "%s"
>>>     <%s>
>>>
>>> in format strings when referring to names (files, nets, netclasses, …).
>>>
>>> For the untranslated strings, I'd prefer either double or single quotes,
>>> while translated messages should probably use the locale appropriate
>>> quoting format.
>>>
>>> Which should it be?
>>>
>>>    Simon
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


References