← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix for 3D model offset

 

JP, Wayne,

Any update on how we want to handle this?

On Mon, Nov 27, 2017 at 9:48 PM, Oliver Walters <
oliver.henry.walters@xxxxxxxxx> wrote:

> jp,
>
> Sorry I forgot to reapply that patch on top.
>
> Updated patch set is attached.
>
> Thanks,
>
> On Mon, Nov 27, 2017 at 6:48 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:
>
>> Le 26/11/2017 à 22:21, Oliver Walters a écrit :
>> > Wayne,
>> >
>> > Please find attached an updated patch set which also fixes 3D model
>> units for the STEP exporter tool.
>> >
>> >
>> >
>> > On Thu, Nov 23, 2017 at 1:59 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx
>> > <mailto:stambaughw@xxxxxxxxx>> wrote:
>> >
>> >     Consistency.  Currently we have two separate units in kicad board
>> and
>> >     footprint files.  This change unifies that issue.  I know it's
>> annoying
>> >     but it is a decision that I made to make the file formatting more
>> >     consistent.  Yes, it is a change that will break some users 3D
>> models
>> >     but I think the long term benefit outweighs the short term
>> annoyance.
>>
>> Hi Oliver and Wayne,
>>
>> I am thinking the "offset" should be written in footprint (and board)
>> files *only* if it is not 0,0,0
>>
>> With this patch, all footprint files will be incompatible with stable
>> version, due to a not used
>> (most of time) parameter.
>> Moreover footprint files have no version identification.
>>
>> --
>> Jean-Pierre CHARRAS
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>

Follow ups

References