kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #32091
Re: Questions on BOARD_COMMIT
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Thu, 30 Nov 2017 08:59:27 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<86668e24-8759-d7d4-2134-4c92b3ebf98c@gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
Hi Wayne,
On 11/29/2017 06:35 PM, Wayne Stambaugh wrote:
[snip]>> KIGFX::VIEW* view = s_PcbEditFrame->GetGalCanvas()->GetView();
>> item->MethodThatModifiesTheItemState();
>> view->Update( item );
>
> Is this safe? What happens when pcbnew is using the legacy canvas?
This is safe as long as view != nullptr, which normally is true.
VIEW::Update() is a lightweight method that only marks VIEW_ITEMs as
dirty, so they are updated the next time VIEW is drawn. When legacy
canvas is active, VIEW_ITEMs are marked as dirty and never refreshed,
nothing more happens.
Regards,
Orson
Attachment:
signature.asc
Description: OpenPGP digital signature
References
