← Back to team overview

kicad-developers team mailing list archive

Re: Fwd: Re: [PATCH] Fix for 3D model offset

 

Le 01/12/2017 à 16:17, Wayne Stambaugh a écrit :
> On 12/01/2017 06:31 AM, jp charras wrote:
>> Le 30/11/2017 à 13:43, Oliver Walters a écrit :
>>> Rebuilt and attached
>>>
>>> On Thu, Nov 30, 2017 at 7:53 PM, jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>>
>>> wrote:
>>>
>>>
>>>     -------- Message transféré --------
>>>     Sujet : Re: [Kicad-developers] [PATCH] Fix for 3D model offset
>>>     Date : Thu, 30 Nov 2017 09:43:05 +0100
>>>     De : jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>>
>>>     Répondre à : KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>     Pour : Oliver Walters <oliver.henry.walters@xxxxxxxxx <mailto:oliver.henry.walters@xxxxxxxxx>>
>>>
>>>     Le 30/11/2017 à 08:38, Oliver Walters a écrit :
>>>     > JP, Wayne,
>>>     >
>>>     > Any update on how we want to handle this?
>>
>> Looks good to me now.
>>
>> Wayne, do you want me to commit these patchs?
>>
> 
> Please commit this patch when you get a chance.  The reason it took me
> so long to pull the trigger on this is that I was trying to think of a
> better way to handle it.  I can not really think of a better solution so
> we will have to live with it unless someone else has a better idea.
> It's best to make the change so everyone will get their complaining over
> with now rather than later.  I think for version 6, I would like to
> revisit the footprint file format given some of its limitations but I'm
> going to hold off on that until after the new schematic file formats are
> done.
> 
> Thanks,
> 
> Wayne
> 

I committed these fixes.

Thanks, Oliver.


-- 
Jean-Pierre CHARRAS


References