kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I'm using cmake 3.9.5 so it may be a new policy warning that isn't
available on older versions of cmake.  In any event, the dependencies on
lib-dependencies should be removed since your patch removes it as a
custom target.

On 12/02/2017 08:36 AM, Nick Østergaard wrote:
> Hmm, strange. I didn't have those warnings, but I mostly tested in a new
> build dir.  I will have a look.
> 
> 2017-12-02 14:15 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>>:
> 
>     Hey Nick,
> 
>     I don't have any build issues with your patch but I get a bunch of CMake
>     warnings (see below) about the undefined dependencies.  Would you please
>     remove the dependencies on lib-dependencies so cmake doesn't complain
>     and resubmit your patch when you get a chance.
> 
>     Thanks,
> 
>     Wayne
> 
>     CMake Warning (dev) at common/CMakeLists.txt:67 (add_dependencies):
>       Policy CMP0046 is not set: Error on non-existent dependency in
>       add_dependencies.  Run "cmake --help-policy CMP0046" for policy
>     details.
>       Use the cmake_policy command to set the policy and suppress this
>     warning.
> 
>       The dependency target "lib-dependencies" of target "gal" does not
>     exist.
>     This warning is for project developers.  Use -Wno-dev to suppress it.
> 
>     CMake Warning (dev) at common/CMakeLists.txt:439 (add_dependencies):
>       Policy CMP0046 is not set: Error on non-existent dependency in
>       add_dependencies.  Run "cmake --help-policy CMP0046" for policy
>     details.
>       Use the cmake_policy command to set the policy and suppress this
>     warning.
> 
>       The dependency target "lib-dependencies" of target "pcbcommon"
>     does not
>       exist.
>     This warning is for project developers.  Use -Wno-dev to suppress it.
> 
>     CMake Warning (dev) at common/CMakeLists.txt:356 (add_dependencies):
>       Policy CMP0046 is not set: Error on non-existent dependency in
>       add_dependencies.  Run "cmake --help-policy CMP0046" for policy
>     details.
>       Use the cmake_policy command to set the policy and suppress this
>     warning.
> 
>       The dependency target "lib-dependencies" of target "common" does not
>     exist.
>     This warning is for project developers.  Use -Wno-dev to suppress it.
> 
>     CMake Warning (dev) at common/CMakeLists.txt:544 (add_dependencies):
>       Policy CMP0046 is not set: Error on non-existent dependency in
>       add_dependencies.  Run "cmake --help-policy CMP0046" for policy
>     details.
>       Use the cmake_policy command to set the policy and suppress this
>     warning.
> 
>       The dependency target "lib-dependencies" of target "dsntest" does not
>       exist.
>     This warning is for project developers.  Use -Wno-dev to suppress it.
> 
>     CMake Warning (dev) at pcbnew/CMakeLists.txt:718 (add_dependencies):
>       Policy CMP0046 is not set: Error on non-existent dependency in
>       add_dependencies.  Run "cmake --help-policy CMP0046" for policy
>     details.
>       Use the cmake_policy command to set the policy and suppress this
>     warning.
> 
>       The dependency target "lib-dependencies" of target "pcbnew" does not
>     exist.
>     This warning is for project developers.  Use -Wno-dev to suppress it.
> 
>     CMake Warning (dev) at pcbnew/CMakeLists.txt:577 (add_dependencies):
>       Policy CMP0046 is not set: Error on non-existent dependency in
>       add_dependencies.  Run "cmake --help-policy CMP0046" for policy
>     details.
>       Use the cmake_policy command to set the policy and suppress this
>     warning.
> 
>       The dependency target "lib-dependencies" of target "github_plugin"
>     does not
>       exist.
>     This warning is for project developers.  Use -Wno-dev to suppress it.
> 
>     CMake Warning (dev) at polygon/CMakeLists.txt:20 (add_dependencies):
>       Policy CMP0046 is not set: Error on non-existent dependency in
>       add_dependencies.  Run "cmake --help-policy CMP0046" for policy
>     details.
>       Use the cmake_policy command to set the policy and suppress this
>     warning.
> 
>       The dependency target "lib-dependencies" of target "polygon" does not
>       exist.
>     This warning is for project developers.  Use -Wno-dev to suppress it.
> 
> 
> 
>     On 12/01/2017 02:28 PM, Nick Østergaard wrote:
>     > Hello
>     >
>     > I just fell over some legacy stuff in the CMakeLists. It seems to
>     not be
>     > used, so therefore I propose to remove it.
>     >
>     > This target seems to only create empty makefiles, tested on linux.
>     And I
>     > can not find any references to it in any of the current
>     CMakeLists. Lets
>     > remove it.
>     >
>     > Nick
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
>