← Back to team overview

kicad-developers team mailing list archive

Re: Zone filling & display speed improvements

 

Le 02/12/2017 à 17:49, Tomasz Wlostowski a écrit :
> On 02/12/17 17:33, jp charras wrote:
>> Le 01/12/2017 à 18:29, jp charras a écrit :
>>> Le 01/12/2017 à 17:12, Tomasz Wlostowski a écrit :
>>>> On 29/11/17 16:10, jp charras wrote:
>>>>> I am using a few board in Kicad demos: interf_u, video, pic_programmer.
>>>>>
>>>>> Also, filled areas are no shown in OpenGL, but are shown in Cairo canvas.
>>>>
>>>> Hi all,
>>>>
>>>> The branch [1] contains a set of improvements in the zone filling
>>>> algorithm. It's several times faster than in the current master branch.
>>>>
>>>> I'd like to merge it soon and move on to fixing P&S issues pending for
>>>> the V5 - I'll greatly appreciate testing and feedback!
>>>>
>>>> Tom
>>>>
>>>> [1] https://github.com/twlostow/kicad-dev/tree/tom-faster-zones-dec01
>>>>
>>>
>>> Hi Tom,
>>>
>>> I just tested this version on W7/32bits, msys2.
>>>
>>> No change since my previous test:
>>> It does not compile without my patch (please apply my patch)
>>> It hangs on refilling zones with any board (and even with no board, just after created a single
>>> copper zone)
>>>
>>> Cheers,
>>>
>>
>> Hi Tom,
>> I made more tests:
>> Looks like hanging is due to open_mp use.
>>
>> When I disable open_mp, refilling zones works fine, and is very fast.
>>
> 
> Hi JP,
> 
> Thanks for the report, I'll try to investigate the OpenMP windows issues
> as soon as I'll manage to compile a Windows Kicad build :)
> 
> Cheers,
> Tom
> 

Thanks Tom.
Exactly, this is the refresh of the progress bar called inside a OpenMP  loop that hangs
( or any call to display something, for instance a wxMessageBox).

If removed, it runs very fast.
However I had a crash when refilling your complex board coming from a conversion from Altium.

Cheers

-- 
Jean-Pierre CHARRAS


References