← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Remove shorted wire (fixes lp:1678449)

 

Seth,

Thanks for the update.  This works great and will be handy feature/bug
fix in Eeschema.  I merged your patch into the development branch.

Cheers,

Wayne

On 12/02/2017 04:50 PM, Seth Hillbrand wrote:
> Hi Wayne-
> 
> Thank makes sense.  The two-pin check was arbitrary, based on the bug
> report's examples.  But there's no fundamental reason not to extend this
> to arbitrary pins.
> 
> The attached patch does this.
> 
> Best-
> Seth
> 
> On Sat, Dec 2, 2017 at 12:23 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Seth,
> 
>     Even though technically we are in a feature freeze and the bug severity
>     is wish list, I would consider this patch since it's fairly trivial.  My
>     only question is why the arbitrary limit of items with only two
>     connection points?  The same bug will occur with any symbol with pins
>     directly across from each other not just symbols with only two pins
>     across from each other.  I'm guessing this will complicate the code but
>     your solution is not complete.
> 
>     Cheers,
> 
>     Wayne
> 
>     On 12/1/2017 7:44 PM, Seth Hillbrand wrote:
>     > ​When laying out a schematic, it is often necessary to ​add
>     resistors or
>     > capacitors to existing wires.  Currently, placing a resistor on
>     top of a
>     > wire in Eeschema will connect both ends, resulting in a short
>     across the
>     > resistor that needs to be removed.
>     >
>     > The attached patch removes the shorted wire when a two-ended component
>     > is placed directly on a wire.
>     >
>     > The associated bug report
>     is  https://bugs.launchpad.net/kicad/+bug/1678449
>     <https://bugs.launchpad.net/kicad/+bug/1678449>
>     >
>     > -Seth
>     >
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References