← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Eeschema wire/bus selection logic

 

I merged your patch.

Thanks,

Wayne

On 12/4/2017 10:26 AM, Seth Hillbrand wrote:
> No worries.  Here's the patch rebased to current master.
> 
> -S
> 
> On Mon, Dec 4, 2017 at 5:01 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Seth,
> 
>     I thought I merged all of your wire/bus patches.  I cannot find this one
>     in my inbox.  Please resend this patch when you get a chance.
> 
>     Thanks,
> 
>     Wayne
> 
>     On 12/3/2017 10:57 PM, Seth Hillbrand wrote:
>     > Gentle ping.
>     >
>     > Wayne, this is the wire-drag fix you requested last week.
>     >
>     > -Seth
>     >
>     > On Thu, Nov 30, 2017 at 6:53 PM, Jon Evans <jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>
>     > <mailto:jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>>> wrote:
>     >
>     >     Gave this a shot, I like this logic, thanks!
>     >
>     >     On Thu, Nov 30, 2017 at 8:55 PM, Seth Hillbrand
>     >     <seth.hillbrand@xxxxxxxxx <mailto:seth.hillbrand@xxxxxxxxx>
>     <mailto:seth.hillbrand@xxxxxxxxx <mailto:seth.hillbrand@xxxxxxxxx>>>
>     wrote:
>     >
>     >         ​Attached is a patch to correct the wire/bus connection
>     logic. 
>     >         Currently, Eeschema will register wires and busses as being
>     >         connected if their endpoints touch.  They will drag
>     together and
>     >         their endpoints will not show the "unconnected" symbols.
>     >
>     >         The attached patch implements the following logic.  The
>     logic is
>     >         largely based on how I like to work with entries, so please
>     >         shout if you feel this is backwards somehow.
>     >         ​
>     >         Dragging:
>     >             - busses and bus-bus entries drag each other when
>     connected
>     >         at endpoints
>     >             - wires and wire-bus entries drag each other when
>     connected
>     >         at endpoints
>     >             - entries do not drag wires or busses when connected
>     to wire
>     >         middles
>     >             - wire-bus entries do not drag busses
>     >             
>     >         Connections:
>     >             - bus-bus entries connect busses to busses but not wires
>     >             - wire-bus entries connect wires to busses but not wire to
>     >         wires or busses to busses
>     >         ​
>     >         ​Best-
>     >         Seth​
>     >
>     >
>     >         _______________________________________________
>     >         Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >         Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >         <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >         More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >         <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >
>     >
>     >
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References