← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Component table view initial columns sizing

 

Wayne,

I created it just by directing a “git show” to a file.
I could apply it to master using “patch -p1 < xxx.patch”.
Of course, I can also try to use “git formal-patch” and resend…


Regards,
Bernhard

> On 5. Dec 2017, at 19:45, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> Bernhard,
> 
> I just tried to merge this patch using `git am` and I'm getting this error:
> 
> fatal: empty ident name (for <>) not allowed
> 
> It looks like you didn't create this patch using `git format-patch`
> and/or you do not have your user name and/or user email set in your git
> config.
> 
> Cheers,
> 
> Wayne
> 
> T
> On 12/5/2017 8:02 AM, Bernhard Stegmaier wrote:
>> Hi,
>> 
>> attached patch fixes initial sizing of “Fields” table columns of component table view.
>> 
>> Only tested on macOS.
>> Please check also on Linux/Windows as I removed some IMHO unneeded/duplicate Update() (and other) calls.
>> 
>> Before:
>> 
>> 
>> 
>> 
>> 
>> After:
>> 
>> 
>> 
>> 
>> 
>> 
>> Regards,
>> Bernhard
>> 
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>

Follow ups

References