kicad-developers team mailing list archive

[Seth Hillbrand <seth.hillbrand@xxxxxxxxx>]

​The attached patch corrects https://bugs.launchpad.net/kicad/+bug/1715158
where pressing delete in pcbnew GAL canvas will delete _both_ a wire​ and
the footprint underneath it.

I know that this bug was marked "triaged" but it bit me on a board and I
didn't notice the missing footprint (was zoomed in) until quite a few
clicks later.

-Seth

From fc77ede4137e2426d6f086f7281bf985c24741df Mon Sep 17 00:00:00 2001
From: Seth Hillbrand <hillbrand@xxxxxxxxxxx>
Date: Tue, 5 Dec 2017 19:39:36 -0800
Subject: [PATCH] pcbnew: Fix multiple delete bug

Delete events when using GAL are handled by only one tool handler
instead of ROUTER_TOOL and EDIT_TOOL both deleting items.

Fixes: lp:1715158
* https://bugs.launchpad.net/kicad/+bug/1715158
---
 pcbnew/router/router_tool.cpp | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/pcbnew/router/router_tool.cpp b/pcbnew/router/router_tool.cpp
index 9de3b0d30..b1db25cc3 100644
--- a/pcbnew/router/router_tool.cpp
+++ b/pcbnew/router/router_tool.cpp
@@ -914,16 +914,6 @@ int ROUTER_TOOL::mainLoop( PNS::ROUTER_MODE aMode )
         {
             m_toolMgr->RunAction( PCB_ACTIONS::layerToggle, true );
         }
-        else if( evt->IsAction( &PCB_ACTIONS::remove ) )
-        {
-            updateStartItem( *evt );
-            deleteTraces( m_startItem, false );
-        }
-        else if( evt->IsAction( &PCB_ACTIONS::removeAlt ) )
-        {
-            updateStartItem( *evt );
-            deleteTraces( m_startItem, true );
-        }
     }
 
     frame->SetNoToolSelected();
-- 
2.11.0