← Back to team overview

kicad-developers team mailing list archive

Re: UTF8 class and wchar_t issues fix

 

Hi Jean-Pierre,

Thank you for the fix, I think you are right. I applied the patch to the
master branch.

Regards,
Orson

On 12/08/2017 01:53 PM, jp charras wrote:
> Hi Orson
> 
> Could you have a look into this patch.
> 
> I am thinking it is also a fix for bug 1737143.
> 
> Currently our UTF8 class has only a append operator for ASCII7 chars.
> But if the code uses something like (it is accepted by the compiler):
> my_utf_8_string += mychar;
> and if mychar is a int (or a wchar_t) containing a non ASCII7 value, the UTF8 string is broken.
> the patch adds a append operator for non ASCII7 value (wchar_t wide chars)
> 
> 
> I am pretty sure this kind of issues also exists in eagle import (when eagle files uses non ASCII7
> chars in texts).
> 
> Thanks.
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References