kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #32364
Re: [PATCH] Bugfix: EDA_RECT to BOX2I generated wrong boxes
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Mon, 11 Dec 2017 10:00:33 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<559ff2b6-44b2-bde9-fce1-2fc8b360342b@andreasbuhr.de>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
Hi Andreas,
Good catch, it must have been like this since the GAL origin. I have
applied your patch to the master branch. Thank you!
Cheers,
Orson
On 12/10/2017 11:08 PM, Andreas Buhr wrote:
> Dear Kicad developers,
>
> The "operator BOX2I() const" of EDA_RECT produced wrong boxes, usually
> much to big. It passed its end-position as second argument to the
> constructor of BOX2I. However, BOX2I expects its size as second
> argument.
>
> This caused a dramatic performance penalty in some
> cases. Took me about a day to figure this out.
>
> Cheers,
> Andreas
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
References
