kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Great, I pushed your patch to the master branch. Thank you for your
contribution.

The line:
+    if(isFillEnabled){
should look like:
+    if( isFillEnabled )
+    {
As I said, nothing I could not fix myself. I realize switching between
projects with different code formatting is not easy, but perhaps you may
find useful either uncrustify or clang-format - we provide configuration
files for both (uncrustify.cfg and _clang-format in the root directory).

Cheers,
Orson

On 12/11/2017 10:20 AM, Andreas Buhr wrote:
> On 12/11/2017 10:11 AM, Maciej Sumiński wrote:
>>
>> There is a minor code formatting violation, that I will fix. I suppose
>> that unfilled polygons have not been used so far, therefore the issue
>> could not be observed. If you use them, can you confirm the behavior is
>> coherent with the cairo backend?
> 
> Hello Orson,
> 
> thanks a lot.
> What was the formatting violation? I'll try to format my coming patches
> better.
> 
> The behavior is coherent with the cairo backend, i.e. the cairo backend
> fills correctly.
> 
> Cheers,
> aDnreas
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature