kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey Jeff,

The preferred method is for you to use git and committing your changes
to your local repo (all commits in git are local) then using `git
format-patch` to submit your patches.  Using `git format-patch`
eliminates the need for busy lead developers from having to enter your
author information and writing a commit message in order to merge your
patch.  I haven't looked at your patches but if you are not aware, kicad
has both a coding stype policy[1] and a commit message policy[2].
Following both these will goe a long way to getting you patches merged.
The other thing that helps is patience.  All of the kicad lead
developers are part time, volunteers, or both so they are typically busy
and not always able to review patches in as timely a manner as we would
like.

Cheers,

Wayne

[1]:
http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html
[2]: http://docs.kicad-pcb.org/doxygen/commit_messages.html

On 12/11/2017 12:45 PM, Jeff Young wrote:
> Hi guys and gals,
> 
> I’ve logged a few bugs that affect me and developed fixes for some of them[1].  After decades of svn and then a few years of retirement I don’t trust my git skills so I added the fixes as patches.  What’s the process for getting them reviewed and committed?
> 
> Thanks,
> Jeff.
> 
> [1]
> https://bugs.launchpad.net/kicad/+bug/1737010
> https://bugs.launchpad.net/kicad/+bug/1737562
> https://bugs.launchpad.net/kicad/+bug/1736836
> https://bugs.launchpad.net/kicad/+bug/1715440
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>